bug#63206: closed ([PATCH] gnu: gnushogi: Fix build.)

[GNU bug Tracking System]

Your message dated Wed, 14 Jun 2023 23:20:51 +0200
with message-id <87352trb9o.fsf_-_@gnu.org>
and subject line Re: bug#63206: [PATCH] gnu: gnushogi: Fix build.
has caused the debbugs.gnu.org bug report #63206,
regarding [PATCH] gnu: gnushogi: Fix build.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
63206: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63206
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: gnushogi: Fix build.
>
>
>
>
> Date: 
>
> Mon,  1 May 2023 23:47:59 +0900
>
>
>
>
> Hello,
>
> This patch fixes GNU Shogi build.
>
> Since the build is now successful, the actual gnushogi executable and
> documents are installed in addition to the COPYING file.
>
> Thanks,
> gemmaro.
>
> * gnu/packages/games.scm (gnushogi): Set linker flag to build program.
> ---
>  gnu/packages/games.scm | 42 +++++++++++++++++++++++++-----------------
>  1 file changed, 25 insertions(+), 17 deletions(-)
>
> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
> index 3391c141e42..a36e2fe55bf 100644
> --- a/gnu/packages/games.scm
> +++ b/gnu/packages/games.scm
> @@ -76,6 +76,7 @@
>  ;;; Copyright © 2022 Hendursaga <hendursaga@aol.com>
>  ;;; Copyright © 2022 Parnikkapore <poomklao@yahoo.com>
>  ;;; Copyright © 2023 Zheng Junjie <873216071@qq.com>
> +;;; Copyright © 2023 gemmaro <gemmaro.dev@gmail.com>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -2012,24 +2013,31 @@ (define-public gnubik
>      (license license:gpl3+)))
>  
>  (define-public gnushogi
> -  (package
> -    (name "gnushogi")
> -    (version "1.4.2")
> -    (source
> -     (origin
> -      (method url-fetch)
> -      (uri (string-append "mirror://gnu/gnushogi/gnushogi-"
> -                          version ".tar.gz"))
> -      (sha256
> -       (base32
> -        "0a9bsl2nbnb138lq0h14jfc5xvz7hpb2bcsj4mjn6g1hcsl4ik0y"))))
> -    (arguments `(#:tests? #f)) ;; No check target.
> -    (build-system gnu-build-system)
> -    (home-page "https://www.gnu.org/software/gnushogi/";)
> -    (synopsis "The game of Shogi (Japanese chess)")
> -    (description  "GNU Shogi is a program that plays the game Shogi (Japanese
> +  (let ((ver "1.4.2")
> +        (revision "2"))
> +    (package
> +      (name "gnushogi")
> +      (version (string-append ver "-" revision))
> +      (source (origin
> +                (method url-fetch)
> +                (uri (string-append "mirror://gnu/gnushogi/gnushogi-" ver
> +                                    ".tar.gz"))
> +                (sha256
> +                 (base32
> +                  "0a9bsl2nbnb138lq0h14jfc5xvz7hpb2bcsj4mjn6g1hcsl4ik0y"))))
> +      (arguments
> +       `(#:phases (modify-phases %standard-phases
> +                    (add-before 'configure 'set-linker-flag
> +                      (lambda _
> +                        (setenv "LDFLAGS" "-z muldefs"))))
> +         #:tests? #f)) ;No check target.
> +      (build-system gnu-build-system)
> +      (home-page "https://www.gnu.org/software/gnushogi/";)
> +      (synopsis "The game of Shogi (Japanese chess)")
> +      (description
> +       "GNU Shogi is a program that plays the game Shogi (Japanese
>  Chess).  It is similar to standard chess but this variant is far more 
> complicated.")
> -    (license license:gpl3+)))
> +      (license license:gpl3+))))
>  
>  (define-public ltris
>    (package
>
> base-commit: 0c6a7e1045cbd06336ef3699734a803a2e4038e5
> -- 
> 2.39.2
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#63206: [PATCH] gnu: gnushogi: Fix build.
>
>
>
>
> Date: 
>
> Wed, 14 Jun 2023 23:20:51 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
>
>
>
>
> gemmaro <gemmaro.dev@gmail.com> skribis:
>
> > * gnu/packages/games.scm (gnushogi)
> > [source]: Fix warnings by prefixing "__FUNCTION__" with "__extension__".
> > [arguments]: Turn off some GCC warnings in C flags.
> > Set the linker flag to build the program.
> > Skip the "--enable-fast-install" flag in the configure phase.
> > Enable the "sizetest" test in the check phase.
> > [synopsis]: Remove "The" so that the sentence doesn't start with it.
>
> Applied, thanks!
>
> Ludo’.
>
>
> --- End Message ---