bug#61825: closed ([PATCH] etc: Default to variables in tempel's git-reference... et al.)

[GNU bug Tracking System]

Your message dated Sun, 18 Jun 2023 09:00:09 +0200
with message-id <5f076d5f3f6ca44ee6edce2031d3420405ff5e9e.camel@gmail.com>
and subject line Re: [PATCH] etc: Default to variables in tempel's 
git-reference... et al.
has caused the debbugs.gnu.org bug report #61825,
regarding [PATCH] etc: Default to variables in tempel's git-reference... et al.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
61825: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=61825
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] etc: Default to variables in tempel's git-reference... et al.
>
>
>
>
> Date: 
>
> Sun, 26 Feb 2023 21:56:33 +0100
>
>
>
>
> Since we encourage using variables rather than magic hashes in the commit
> fields, e.g. (commit version) and (commit commit), the default for
> tempel to use quoted strings is rather off.  Thus, let the placeholder reflect
> actual usage.
>
> * etc/snippets/tempel/scheme-mode (git-reference...)[commit]: Use field name
> as placeholder and don't quote value.
> (svn-reference..., bzr-reference...)[revision]: Likewise.
> (hg-reference...)[changeset]: Likewise.
> ---
>  etc/snippets/tempel/scheme-mode | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/etc/snippets/tempel/scheme-mode b/etc/snippets/tempel/scheme-mode
> index 54cb8e40a9..ef73a1e595 100644
> --- a/etc/snippets/tempel/scheme-mode
> +++ b/etc/snippets/tempel/scheme-mode
> @@ -56,12 +56,12 @@ scheme-mode
>  (git-reference...
>   "(git-reference"
>   n> "(url \"" p "\")"
> - n> "(commit \"" p "\"))")
> + n> "(commit " (p "commit") "))")
>  
>  (svn-reference...
>   "(svn-reference"
>   n> "(url \"" p "\")"
> - n> "(revision \"" p "\"))")
> + n> "(revision " (p "revision") "))")
>  
>  (cvs-reference...
>   "(cvs-reference"
> @@ -72,12 +72,12 @@ scheme-mode
>  (hg-reference...
>   "(hg-reference"
>   n> "(url \"" p "\")"
> - n> "(changeset \"" p "\"))")
> + n> "(changeset " (p "changeset") "))")
>  
>  (bzr-reference...
>   "(bzr-reference"
>   n> "(url \"" p "\")"
> - n> "(revision \"" p "\"))")
> + n> "(revision " (p "revision") "))")
>  
>  (:phases\ "#:phases (modify-phases %standard-phases"
>            n> p ")")
> -- 
> 2.39.1
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [PATCH] etc: Default to variables in tempel's git-reference... et al.
>
>
>
>
> Date: 
>
> Sun, 18 Jun 2023 09:00:09 +0200
>
>
>
>
> User-agent: 
>
> Evolution 3.46.4 
>
>
>
>
> Am Sonntag, dem 05.03.2023 um 10:03 +0100 schrieb Liliana Marie
> Prikler:
> > Am Sonntag, dem 26.02.2023 um 21:56 +0100 schrieb Liliana Marie
> > Prikler:
> > > Since we encourage using variables rather than magic hashes in the
> > > commit fields, e.g. (commit version) and (commit commit), the
> > > default
> > > for tempel to use quoted strings is rather off.  Thus, let the
> > > placeholder reflect actual usage.
> > > 
> > > * etc/snippets/tempel/scheme-mode (git-reference...)[commit]: Use
> > > field name
> > > as placeholder and don't quote value.
> > > (svn-reference..., bzr-reference...)[revision]: Likewise.
> > > (hg-reference...)[changeset]: Likewise.
> > Pushed.
> Forgot to mark as done.
>
>
>
> --- End Message ---