bug#64344: closed ([PATCH] Make calculator work with customized mode-line)

[GNU bug Tracking System]

Your message dated Thu, 29 Jun 2023 21:22:45 +0300
with message-id <838rc2t9fu.fsf@gnu.org>
and subject line Re: [PATCH] Make calculator work with customized mode-line
has caused the debbugs.gnu.org bug report #64344,
regarding [PATCH] Make calculator work with customized mode-line
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
64344: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=64344
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: [PATCH] Make calculator work with customized mode-line Date: Wed, 28 Jun 2023 13:23:45 -0500

calculator.el doesn’t work after customizing the mode-line. It assumes
the line-width is always an integer but after using customize it is a
dotted list.

  - emacs -Q
  - M-x customize-apropos-faces RET mode-line RET
  - Ensure ‘mode-line-face’ has a box property with vertical and
    horizontal widths. The default config includes these already.
  - Set for current session
  - M-x calculator RET
  => calculator: Wrong type argument: number-or-marker-p, (1 . -1)

In GNU Emacs 30.0.50 (build 6, x86_64-pc-linux-gnu, GTK+ Version
 3.24.38, cairo version 1.17.8) of 2023-06-28 built on localhost
Repository revision: c5d6102313076b83526dc79bfb563621671fb70b
Repository branch: master
System Description: Fedora Linux 38 (Workstation Edition)

Configured using:
 'configure --with-native-compilation --with-pgtk'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
JSON LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 MODULES NATIVE_COMP NOTIFY
INOTIFY PDUMPER PGTK PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF
TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XIM GTK3 ZLIB

0001-lisp-calculator-el--calculator-need-3-lines---Ch.patch
Description: [PATCH] * lisp/calculator.el (calculator-need-3-lines): Check type

signature.asc
Description: PGP signature

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [PATCH] Make calculator work with customized mode-line
>
>
>
>
> Date: 
>
> Thu, 29 Jun 2023 21:22:45 +0300
>
>
>
>
> > From: john muhl <jm@pub.pink>
> > Cc: 64344@debbugs.gnu.org
> > Date: Thu, 29 Jun 2023 10:12:06 -0500
> > 
> > > Shouldn't that be 'consp' instead?  'listp' returns non-nil for nil
> > > argument.
> > 
> > I’m not expert enough to say more than that either way works to fix the
> > issue. Originally I did the ‘(cdr lh)’ unconditionally and got an error
> > mentioning ‘listp’ so I just used that when I added the condition; if it
> > had said ‘conps’ I would have used that.
> > 
> > Here is the patch with ‘consp’ instead.
>
> Thanks.  That still uses 'listp', so I fixed that manually.
>
> This is now installed on the emacs-29 branch; closing the bug.
>
>
> --- End Message ---