bug#64930: closed ([PATCH] guix: Also print the user when SSH auth fails.)

[GNU bug Tracking System]

Your message dated Tue, 22 Aug 2023 11:07:26 +0200
with message-id <87pm3f5ttd.fsf_-_@gnu.org>
and subject line Re: bug#64930: [PATCH] guix: Also print the user when SSH auth 
fails.
has caused the debbugs.gnu.org bug report #64930,
regarding [PATCH] guix: Also print the user when SSH auth fails.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
64930: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=64930
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] guix: Also print the user when SSH auth fails.
>
>
>
>
> Date: 
>
> Sat, 29 Jul 2023 14:02:37 +0200
>
>
>
>
> ---
>
> i have added this when i was debugging a guix deploy issue,
> and i thought it should be useful for others, too.
>
>  guix/ssh.scm | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/guix/ssh.scm b/guix/ssh.scm
> index b7b9807ebf..91d61fc3c0 100644
> --- a/guix/ssh.scm
> +++ b/guix/ssh.scm
> @@ -175,8 +175,8 @@ (define* (open-ssh-session host #:key user port identity
>               (disconnect! session)
>               (raise (condition
>                       (&message
> -                      (message (format #f (G_ "SSH authentication failed for 
> '~a': ~a~%")
> -                                       host (get-error session)))))))))))
> +                      (message (format #f (G_ "SSH authentication failed for 
> '~a@~a': ~a~%")
> +                                       user host (get-error session)))))))))))
>        (x
>         ;; Connection failed or timeout expired.
>         (raise (formatted-message (G_ "SSH connection to '~a' failed: ~a~%")
>
> base-commit: e43cbeafd1b632f39b08b3644af5230d5350a656
> prerequisite-patch-id: 6793c8ad24215c5f14ce71a4741fff5f6ccd7eeb
> prerequisite-patch-id: 3a8dd737d11f37987641af9bc7f512a0bb1a1591
> prerequisite-patch-id: f6456f2bf0b7b078318d16b958c14816eb45ace5
> prerequisite-patch-id: 52e0d371350dbeb839990acd0bbe70bc5b5b995b
> -- 
> 2.40.1
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#64930: [PATCH] guix: Also print the user when SSH auth fails.
>
>
>
>
> Date: 
>
> Tue, 22 Aug 2023 11:07:26 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
>
>
>
>
> Hi,
>
> Simon Tournier <zimon.toutoune@gmail.com> skribis:
>
> > On Sat, 29 Jul 2023 at 14:02, Attila Lendvai <attila.lendvai@gmail.com> wrote:
> >
> >> -                      (message (format #f (G_ "SSH authentication failed 
> >> for '~a': ~a~%")
> >> -                                       host (get-error session)))))))))))
> >> +                      (message (format #f (G_ "SSH authentication failed 
> >> for '~a@~a': ~a~%")
> >> +                                       user host (get-error 
> >> session)))))))))))
> >
> > This LGTM.  Is it possible that ’user’ is not set?
>
> Right, USER can be #f.  I fixed this and applied it.
>
> Thanks Attila & Simon!
>
> Ludo’.
>
>
> --- End Message ---