bug#64275: closed (30.0.50; [PATCH] Improve sigil font-lock match for elixir-ts-mode)

[GNU bug Tracking System]

Your message dated Thu, 26 Oct 2023 03:27:13 +0300
with message-id <a30e1a1f-88d6-a754-3854-d415a63655e3@gutov.dev>
and subject line Re: bug#64275: 30.0.50; [PATCH] Improve sigil font-lock match 
for elixir-ts-mode
has caused the debbugs.gnu.org bug report #64275,
regarding 30.0.50; [PATCH] Improve sigil font-lock match for elixir-ts-mode
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
64275: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=64275
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: 30.0.50; [PATCH] Improve sigil font-lock match for elixir-ts-mode Date: Sat, 24 Jun 2023 22:14:17 +0200 User-agent: mu4e 1.9.3; emacs 30.0.50

This patch updates the sigil matching for Elixir. We don't need to know what the sigil is to be able to set the font. The one exception is

regex via a sigil.

0001-Fix-eglot-imenu-when-the-server-does-not-support-it.patch
Description: Text Data

Wilhelm

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#64275: 30.0.50; [PATCH] Improve sigil font-lock match for elixir-ts-mode
>
>
>
>
> Date: 
>
> Thu, 26 Oct 2023 03:27:13 +0300
>
>
>
>
> User-agent: 
>
> Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0
>
>
>
>
> On 21/10/2023 10:39, Wilhelm Kirschbaum wrote:
> >      >>>
> >      >>> I'm not sure what you meant by the last sentence, sorry. What
> >      >>> do
> >      >>> you
> >      >>> think about the below?
> >      >>>
> >      >>>   (sigil (sigil_name) @elixir-ts-font-sigil-name-face)
> >      >>>   @font-lock-string-face)
> >      >>
> >      >> Sorry for the late reply.  I believe the following patch is
> >      >> more
> >      >> appropriate as it will apply the sigil font to the entire
> >      >> sigil, but
> >      >> also respect the regex face.  We can add string specific
> >      >> matches
> >      >> later,
> >      >> but happy just to simplify what we have and fix apply
> >      >> appropriate
> >      >> font
> >      >> to previously unmatched sigils.
> >      >>
> >      >> [2. text/x-patch;
> >      >> 0001-Simplify-sigil-font-lock-match-for-elixir-ts-mode.patch]...
> >      >
> >      > Actually, the above patch breaks the embedded HEEx sigils'
> >      > font. We
> >      > have to exclude it when doing a general match.  Attached works
> >      > with ~H
> >      > sigils as well.  Please ignore the previous patch and install
> >      > this
> >      > one.
> >      >
> >      > [2. text/x-patch;
> >      > 0001-Simplify-sigil-font-lock-match-for-elixir-ts-mode(1).patch]...
> >
> >
> >     Sorry :(. I am finding more edge cases.  Maybe let me test it this
> >     properly this week before we make any changes.
> >
> >
> > I tested this patch for a while now and it looks like the best approach
> > for handling regex sigils, but with an appropriate fallback.
> >
> > If this can be installed, it will be appreciated.
>
> Thanks! Installed, and closing.
>
>
> --- End Message ---