bug#58801: closed ([PATCH] Autoload the `calc-eval-error' variable)

[GNU bug Tracking System]

Your message dated Sun, 5 Nov 2023 08:38:21 -0800
with message-id 
<CADwFkmktBD8jbDxqoFR0Kp-qKpxTzbYiikPHB+juAH=SNGb3pg@mail.gmail.com>
and subject line Re: bug#58801: [PATCH] Autoload the `calc-eval-error' variable
has caused the debbugs.gnu.org bug report #58801,
regarding [PATCH] Autoload the `calc-eval-error' variable
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
58801: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=58801
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: [PATCH] Autoload the `calc-eval-error' variable Date: Wed, 26 Oct 2022 10:02:50 -0700

Tags: patch

(rationale in the patch)

In GNU Emacs 29.0.50 (build 8, x86_64-pc-linux-gnu, GTK+ Version
 3.24.34, cairo version 1.16.0) of 2022-10-25 built on naz
Repository revision: 9d7ba2b1998afc3664c37d9d1b6f6ca2d68356e9
Repository branch: feature/noverlay
System Description: Debian GNU/Linux bookworm/sid

Configured using:
 'configure 'CFLAGS=-Og -g3' 'CXXFLAGS=-Og -g3' --enable-checking=yes
 --enable-check-lisp-object-type --with-pgtk'

0001-Autoload-the-calc-eval-error-variable.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#58801: [PATCH] Autoload the `calc-eval-error' variable
>
>
>
>
> Date: 
>
> Sun, 5 Nov 2023 08:38:21 -0800
>
>
>
>
> Version: 30.1
>
> Stefan Kangas <stefankangas@gmail.com> writes:
>
> > We typically avoid autoloading variables, and I'm not sure it's
> > justified here.  See (info "(elisp) When to Autoload") for details.
> >
> > Could we instead just declare it in calc.el?  I believe that should
> > silence any warnings from the byte-compiler.  It's a one line change:
> >
> >     (defvar calc-eval-error)
> >
> > Or will that not work in your use case for some reason?
> >
> >> (In the particular case of the Calc package, dozens of functions and
> >> variables are already autoloaded.  The omission of `calc-eval-error'
> >> also seems more an oversight than intentional.)
> >
> > FWIW, I couldn't find any autoloaded variables in calc-loaddefs.el.
> > What am I missing?
>
> No further comments here within 2 months, so I've pushed the above
> proposed fix to master, and I'm closing this bug.
>
> If this is still an issue, please reply to this email (use "Reply to
> all" in your email client) and we can reopen the bug report.
>
> [1: ad82bc9b29e]: 2023-11-05 17:36:21 +0100
>   Declare calc-eval-error in calc.el
>   
> https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=ad82bc9b29eacad29a441bbb4e87bd09ef1ff1c4
>
>
> --- End Message ---