emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#67031: closed ([PATCH] Fix typescript-ts-mode indentation in unbrack


From: GNU bug Tracking System
Subject: bug#67031: closed ([PATCH] Fix typescript-ts-mode indentation in unbracketed statements)
Date: Tue, 21 Nov 2023 14:10:02 +0000

Your message dated Tue, 21 Nov 2023 16:09:34 +0200
with message-id <298eca0b-01f5-d852-d066-384f1c1ee717@gutov.dev>
and subject line Re: bug#67031: [PATCH] Fix typescript-ts-mode indentation in 
unbracketed statements
has caused the debbugs.gnu.org bug report #67031,
regarding [PATCH] Fix typescript-ts-mode indentation in unbracketed statements
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
67031: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=67031
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
--- Begin Message --- Subject: [PATCH] Fix typescript-ts-mode indentation in unbracketed statements Date: Thu, 9 Nov 2023 17:29:21 -0800
Tags: patch


* lisp/progmodes/typescript-ts-mode.el
(typescript-ts-mode--indent-rules): fix indentation after statements
without brackets

Bug: There are no indentation rules for statement bodies following
if/for/for_in/do/while statements without brackets.

Recipe to reproduce:
In a `typescript-ts-mode` buffer with the following code,

    if (true)
    console.log('No indent here')

Try to indent the second line.

In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
3.24.33, cairo version 1.16.0) of 2023-11-05 built on noah-X580VD
Repository revision: b819b8d6e90337b4cb36b35c2c6d0112c90a8e24
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101004
System Description: Ubuntu 22.04.3 LTS

Configured using:
 'configure --prefix=/usr/local --with-modules --with-tree-sitter
--with-threads --with-x-toolkit=gtk3 --with-xwidgets --with-gnutls
--with-json --with-mailutils --with-jpeg --with-png --with-rsvg
--with-tiff --with-xml2 --with-xpm --with-imagemagick CC=gcc-12
CXX=gcc-12'

Attachment: typescript-ts-mode-indentation.patch
Description: Text Data


--- End Message ---
--- Begin Message --- Subject: Re: bug#67031: [PATCH] Fix typescript-ts-mode indentation in unbracketed statements Date: Tue, 21 Nov 2023 16:09:34 +0200 User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0
Version: 29.2

On 21/11/2023 13:44, Eli Zaretskii wrote:
From: Noah Peart<noah.v.peart@gmail.com>
Date: Mon, 20 Nov 2023 20:41:49 -0800
Cc: Dmitry Gutov<dmitry@gutov.dev>,casouri@gmail.com,67031@debbugs.gnu.org

I believe my copyright assignment is on file - Eli, I think you checked for me
last month.
Yes, sorry, my bad.  I was coffee-challenged and therefore confused.

So we can install this right away.

Thanks, installed.

I've also backported the test setup from master, so it'll be easier to add changes like this to Emacs 29.2 in the future.


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]