bug#67365: closed ([PATCH core-updates] gnu: gitless: fix definition.)

[GNU bug Tracking System]

Your message dated Wed, 22 Nov 2023 20:17:48 +0800
with message-id <878r6qm177.wl-hako@ultrarare.space>
and subject line Re: [bug#67365] [PATCH core-updates] gnu: gitless: fix 
definition.
has caused the debbugs.gnu.org bug report #67365,
regarding [PATCH core-updates] gnu: gitless: fix definition.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
67365: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=67365
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH core-updates] gnu: gitless: fix definition.
>
>
>
>
> Date: 
>
> Wed, 22 Nov 2023 19:00:17 +0800
>
>
>
>
> gnu/packages/version-control.scm(gitless)[arguments] move #~ to #:phases,
> disable test.
>
> Change-Id: Ibe3cdbd24fc0b27a15a880a2a45cb0cd8cfde84d
> ---
>  gnu/packages/version-control.scm | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
> index c366a41342..b687d184c2 100644
> --- a/gnu/packages/version-control.scm
> +++ b/gnu/packages/version-control.scm
> @@ -50,6 +50,7 @@
>  ;;; Copyright ?? 2023 Nicolas Graves <ngraves@ngraves.fr>
>  ;;; Copyright ?? 2023 Bruno Victal <mirai@makinata.eu>
>  ;;; Copyright ?? 2023 Kjartan Oli Agustsson <kjartanoli@disroot.org>
> +;;; Copyright ?? 2023 Zheng Junjie <873216071@qq.com>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -776,9 +777,10 @@ (define-public gitless
>         (file-name (git-file-name name version))))
>      (build-system python-build-system)
>      (arguments
> -     #~(list
> -        #:phases
> -        (modify-phases %standard-phases
> +     (list
> +      #:tests? #f ;; FIXME: fix test
> +      #:phases
> +      #~(modify-phases %standard-phases
>            (add-before 'build 'loosen-requirements
>              (lambda _
>                (substitute* "setup.py"
>
> base-commit: 1bca46690c6240310befc6208fb24a044bd4b437
> -- 
> 2.41.0
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#67365] [PATCH core-updates] gnu: gitless: fix definition.
>
>
>
>
> Date: 
>
> Wed, 22 Nov 2023 20:17:48 +0800
>
>
>
>
> Hi,
>
> On Wed, 22 Nov 2023 19:00:17 +0800,
> Zheng Junjie wrote:
> > 
> > gnu/packages/version-control.scm(gitless)[arguments] move #~ to #:phases,
> > disable test.
> > 
> > Change-Id: Ibe3cdbd24fc0b27a15a880a2a45cb0cd8cfde84d
> > ---
> >  gnu/packages/version-control.scm | 8 +++++---
> >  1 file changed, 5 insertions(+), 3 deletions(-)
> > 
> > diff --git a/gnu/packages/version-control.scm 
> > b/gnu/packages/version-control.scm
> > index c366a41342..b687d184c2 100644
> > --- a/gnu/packages/version-control.scm
> > +++ b/gnu/packages/version-control.scm
> > @@ -50,6 +50,7 @@
> >  ;;; Copyright © 2023 Nicolas Graves <ngraves@ngraves.fr>
> >  ;;; Copyright © 2023 Bruno Victal <mirai@makinata.eu>
> >  ;;; Copyright © 2023 Kjartan Oli Agustsson <kjartanoli@disroot.org>
> > +;;; Copyright © 2023 Zheng Junjie <873216071@qq.com>
> >  ;;;
> >  ;;; This file is part of GNU Guix.
> >  ;;;
> > @@ -776,9 +777,10 @@ (define-public gitless
> >         (file-name (git-file-name name version))))
> >      (build-system python-build-system)
> >      (arguments
> > -     #~(list
> > -        #:phases
> > -        (modify-phases %standard-phases
> > +     (list
> > +      #:tests? #f ;; FIXME: fix test
> > +      #:phases
> > +      #~(modify-phases %standard-phases
> >            (add-before 'build 'loosen-requirements
> >              (lambda _
> >                (substitute* "setup.py"
> > 
> > base-commit: 1bca46690c6240310befc6208fb24a044bd4b437
> > -- 
> > 2.41.0
>
>
> Applied (without the #:tests? change, I'll address it later), thank you!
>
>
> --- End Message ---