bug#67452: closed (30.0.50; [PATCH] Make split-root-window functions handle argument)

[GNU bug Tracking System]

Your message dated Wed, 29 Nov 2023 16:16:19 +0200
with message-id <838r6g7ih8.fsf@gnu.org>
and subject line Re: bug#67452: 30.0.50; [PATCH] Make split-root-window 
functions handle argument
has caused the debbugs.gnu.org bug report #67452,
regarding 30.0.50; [PATCH] Make split-root-window functions handle argument
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
67452: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=67452
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: 30.0.50; [PATCH] Make split-root-window functions handle argument Date: Sun, 26 Nov 2023 00:42:54 -0800 User-agent: Mozilla Thunderbird

Hello,

I noticed the split-root-window-below and split-root-window-right commands fail when passing an argument using C-u:

split-root-window-right: Wrong type argument: number-or-marker-p, (4)

I have edited these functions to remedy this error, and attached a patch. I hope that the changes are satisfactory.

Best,

Cy

0001-Make-split-root-window-functions-handle-argument.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#67452: 30.0.50; [PATCH] Make split-root-window functions handle argument
>
>
>
>
> Date: 
>
> Wed, 29 Nov 2023 16:16:19 +0200
>
>
>
>
> > Date: Mon, 27 Nov 2023 10:20:36 +0100
> > Cc: 67452@debbugs.gnu.org, hugo@heagren.com
> > From: martin rudalics <rudalics@gmx.at>
> > 
> >  > I guess we should do this for consistency with other split-window-*
> >  > commands?  Martin, any reasons the split-root-window-* commands didn't
> >  > follow the example of the corresponding split-window-* commands?
> > 
> > No idea.  Maybe Hugo Heagren can tell.
> > 
> >  > In any case, to make the split-root-window-* commands support C-u we
> >  > just need to change the interactive spec from "P" to "p", there's no
> >  > need for anything more complex.
> > 
> > I think so.  Here 'split-window-below' and 'split-window-right' use
> > 
> >    (let* ((size (and size (prefix-numeric-value size)))
> > 
> > maybe to "just work" when being passed an invalid SIZE argument but I
> > don't remember the details.
>
> Thanks, I've now installed the change on the emacs-29 branch, using
> the "p" interactive spec, and I'm closing this bug.
>
>
> --- End Message ---