bug#49437: closed ([PATCH core-updates] build-system/qt: Fix build failures when)

[GNU bug Tracking System]

Your message dated Sat, 20 Jan 2024 16:11:25 -0500
with message-id <87le8jd81u.fsf_-_@gmail.com>
and subject line Re: bug#49437: [PATCH core-updates] build-system/qt: Fix build 
failures when
has caused the debbugs.gnu.org bug report #49437,
regarding [PATCH core-updates] build-system/qt: Fix build failures when
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
49437: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=49437
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: [PATCH core-updates] build-system/qt: Fix build failures when Date: Tue, 06 Jul 2021 13:25:50 +0200 User-agent: Evolution 3.34.2

Hi guix,

From the commit message:

‘One of the features of 'qt-build-system' is that it automatically
creates wrappers, but it needs 'bash' (or 'bash-minimal') to do
so.  If "bin/bash" doesn't exist among the 'inputs', then
'search-input-file' (used by 'wrap-all-programs') will raise an
exception.  Address this exception by adding "bash-minimal" to
'host-inputs' when cross-compiling.

This change does not impact native compilation; the derivations
for natively-compiled packages remain identical.’

I am unable to test this at the moment (too little substitutes
for core-updates, too little processing power locally ...), but
I intent to do so later.

Greetings,
Maxime/

signature.asc
Description: This is a digitally signed message part

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#49437: [PATCH core-updates] build-system/qt: Fix build failures when
>
>
>
>
> Date: 
>
> Sat, 20 Jan 2024 16:11:25 -0500
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13)
>
>
>
>
> Hi,
>
> Maxime Devos <maximedevos@telenet.be> writes:
>
> > Mathieu Othacehe schreef op do 08-07-2021 om 16:45 [+0200]:
> >> Hey Maxime,
> >> 
> >> > I am unable to test this at the moment (too little substitutes
> >> > for core-updates, too little processing power locally ...), but
> >> > I intent to do so later.
> >> 
> >> I think you are missing the attached patch here.
> >
> > Now attached!
> >
> > Greetings,
> > Maxime.
> >
> > From b9e46156e1f35303b56fbe2ed4694385b6104214 Mon Sep 17 00:00:00 2001
> > From: Maxime Devos <maximedevos@telenet.be>
> > Date: Tue, 6 Jul 2021 10:57:49 +0200
> > Subject: [PATCH core-updates] build-system/qt: Fix build failures when
> >  cross-compiling.
> >
> > One of the features of 'qt-build-system' is that it automatically
> > creates wrappers, but it needs 'bash' (or 'bash-minimal') to do
> > so.  If "bin/bash" doesn't exist among the 'inputs', then
> > 'search-input-file' (used by 'wrap-all-programs') will raise an
> > exception.  Address this exception by adding "bash-minimal" to
> > 'host-inputs' when cross-compiling.
> >
> > This change does not impact native compilation; the derivations
> > for natively-compiled packages remain identical.
> >
> > * guix/build-system/qt.scm
> >   (bash-for-wrappers): New procedure.
> >   (lower): Add 'bash-minimal' to 'host-inputs' when cross-compiling.
>
> I don't think our Qt packages can be already cross-built; hence there's
> no current value in adding this before addressing cross-compilation of
> the qt-build-system in the first place.
>
> Also, 'guix lint' would still complain, so for now I'm opting to close
> this without applying it.
>
> -- 
> Thanks,
> Maxim
>
>
> --- End Message ---