bug#68589: closed ([PATCH] Add guix-home-service-type)

[GNU bug Tracking System]

Your message dated Mon, 29 Apr 2024 12:16:08 +0200
with message-id <87frv4fp93.fsf@gnu.org>
and subject line Re: [bug#68589] [PATCH] Add guix-home-service-type
has caused the debbugs.gnu.org bug report #68589,
regarding [PATCH] Add guix-home-service-type
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
68589: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=68589
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] Add guix-home-service-type
>
>
>
>
> Date: 
>
> Fri, 19 Jan 2024 15:12:13 +0100
>
>
>
>
> User-agent: 
>
> mu4e 1.10.8; emacs 30.0.50
>
>
>
>
> Hoping to upstream this nice service from RDE. This service allows to
> embed a home environment in a operating-system declaration.
>
> Original source: 
> https://git.sr.ht/~abcdw/rde/tree/master/item/src/gnu/services/home.scm
>
> Change-Id: I42976cae9dd1580dc07dc866cd851294c7921725
> ---
>  gnu/services/home.scm | 47 +++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 47 insertions(+)
>  create mode 100644 gnu/services/home.scm
>
> diff --git a/gnu/services/home.scm b/gnu/services/home.scm
> new file mode 100644
> index 0000000000..868eafbec8
> --- /dev/null
> +++ b/gnu/services/home.scm
> @@ -0,0 +1,47 @@
> +(define-module (gnu services home)
> +  #:use-module (gnu services)
> +  #:use-module (gnu services shepherd)
> +
> +  #:use-module (guix gexp)
> +  #:use-module (guix packages)
> +  #:use-module (guix records)
> +
> +  #:export (guix-home-service-type))
> +
> +
> +(define (guix-home-shepherd-service config)
> +  (map
> +   (lambda (x)
> +     (let ((user (car x))
> +           (he (cdr x)))
> +       (shepherd-service
> +        (documentation "Activate Guix Home.")
> +        ;; Originally requirement was user-homes, but for recently it stopped
> +        ;; working, seems like it was executed too early and didn't work, so
> +        ;; we switched to term-tty1.
> +        (requirement '(term-tty1))
> +        (provision (list (symbol-append 'guix-home- (string->symbol user))))
> +        (one-shot? #t)
> +        (auto-start? #t)
> +        (start #~(make-forkexec-constructor
> +                  '(#$(file-append he "/activate"))
> +                  #:user #$user
> +                  #:environment-variables
> +                  (list (string-append "HOME=" (passwd:dir (getpw #$user))))
> +                  #:group (group:name (getgrgid (passwd:gid (getpw #$user))))))
> +        (stop #~(make-kill-destructor)))))
> +     config))
> +
> +(define (guix-home-gc-roots config)
> +  (map cdr config))
> +
> +(define guix-home-service-type
> +  (service-type
> +   (name 'guix-home)
> +   (description "Setups home-environments specified in the value.")
> +   (extensions (list (service-extension
> +                      shepherd-root-service-type
> +                      guix-home-shepherd-service)))
> +   ;; (compose append)
> +   ;; (extend append)
> +   (default-value '())))
>
> base-commit: 162d6a2fdd6af13272967c77347a54934ecb45e6
> --
> 2.41.0
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#68589] [PATCH] Add guix-home-service-type
>
>
>
>
> Date: 
>
> Mon, 29 Apr 2024 12:16:08 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13)
>
>
>
>
> Hi,
>
> Richard Sent <richard@freakingpenguin.com> skribis:
>
> > I accidentally submitted a patch very similar to this one at
> > https://issues.guix.gnu.org/69781. FYI in case anyone winds up iterating
> > on this version of the patch.
> >
> > Not sure how to merge debbugs issues. I did implement most of the
> > feedback mentioned in this issue and resolved a couple of other
> > problems.
>
> Oops indeed.  Lars, I’m closing this issue, but please let us know if
> you have suggestions!
>
> Ludo’.
>
>
> --- End Message ---