bug#69315: closed ([PATCH] Build system fixes)

[GNU bug Tracking System]

Your message dated Mon, 06 May 2024 11:37:13 +0200
with message-id <874jbbmgc6.fsf@gnu.org>
and subject line Re: bug#69315: [PATCH] Build system fixes
has caused the debbugs.gnu.org bug report #69315,
regarding [PATCH] Build system fixes
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
69315: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=69315
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: [PATCH] Build system fixes Date: Thu, 22 Feb 2024 22:14:04 +0100 User-agent: Evolution 3.50.4

Dear Guile maintainers,

please find attached two patches for changes that we have been carrying
downstream in LilyPond so far: one fix to make a sed invocation fully
portable, and a fix for cross-compilation in out-of-tree-builds.

Regards
Jonas

0001-build-Make-sed-invocation-fully-portable.patch
Description: Text Data

0002-build-Fix-cross-compilation-in-out-of-tree-builds.patch
Description: Text Data

signature.asc
Description: This is a digitally signed message part

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#69315: [PATCH] Build system fixes
>
>
>
>
> Date: 
>
> Mon, 06 May 2024 11:37:13 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13)
>
>
>
>
> Hi Jonas,
>
> Jonas Hahnfeld <hahnjo@hahnjo.de> skribis:
>
> > From 428d1b17c5f664d3cb8da4cd5687bd47bdd87877 Mon Sep 17 00:00:00 2001
> > From: Jonas Hahnfeld <hahnjo@hahnjo.de>
> > Date: Thu, 22 Feb 2024 21:57:41 +0100
> > Subject: [PATCH 1/2] build: Make sed invocation fully portable
> >
> > Commit 08041d216f attempted to make the "invocation compatible with
> > BSD sed", but moving '-i' first does not solve the problem because
> > it still requires to pass an argument. Instead just redirect the
> > instantiated output into a temporary file and install that.
> >
> > * libguile/Makefile.am: Remove '-i' from INSTANTIATE.
>
> [...]
>
> > From ad01912391b449fcf547ac52ed468f9b572cb0ad Mon Sep 17 00:00:00 2001
> > From: Jonas Hahnfeld <hahnjo@hahnjo.de>
> > Date: Thu, 22 Feb 2024 22:10:06 +0100
> > Subject: [PATCH 2/2] build: Fix cross-compilation in out-of-tree-builds
> >
> > gen-scmconfig.h is generated in libguile, not $(top_builddir).
> >
> > * libguile/Makefile.am: Add '-I.' when compiling gen-scmconfig.o.
>
> Finally applied both, thanks!
>
> Ludo’.
>
>
> --- End Message ---