--- Begin Message ---
|
Subject: |
[PATCH] Fix error messages containing format strings |
|
Date: |
Tue, 2 Apr 2024 09:52:34 +0200 |
|
User-agent: |
Mozilla Thunderbird |
Hi all,
I recently ran into the issue that some error messages in Guile are not
formatted properly.
As a simple reproducer, fire up a REPL and do
,option on-error 'foo
Which will yield
"While executing meta-command:
Bad on-error value ~a; expected one of ~a foo (debug backtrace report pass)"
The reason is that format strings occurring in the message are
escaped, see `module/ice-9/boot-9.scm` and
`module/language/tree-il/primitives.scm`.
So a call of
`(error "Wrong argument: ~a" 42)`
is rendered as
"Wrong argument: ~a 42"
Some callers did not take this behavior into account.
Patch attached.
Michael
0001-Fix-error-messages-containing-format-strings.patch
Description: Text document
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: bug#70142: [PATCH] Fix error messages containing format strings |
|
Date: |
Mon, 06 May 2024 11:42:34 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Hi Michael,
Michael Käppler <xmichael-k@web.de> skribis:
> The reason is that format strings occurring in the message are
> escaped, see `module/ice-9/boot-9.scm` and
> `module/language/tree-il/primitives.scm`.
>
> So a call of
>
> `(error "Wrong argument: ~a" 42)`
>
> is rendered as
>
> "Wrong argument: ~a 42"
> Some callers did not take this behavior into account.
Good catch, applied. Thanks!
Ludo’.
--- End Message ---