bug#70390: closed ([PATCH 0/2] Add s-exp support to Notmuch)

[GNU bug Tracking System]

Your message dated Mon, 13 May 2024 21:43:33 +0100
with message-id <8734ql30ju.fsf@cbaines.net>
and subject line Re: [bug#70390] QA review for 70390
has caused the debbugs.gnu.org bug report #70390,
regarding [PATCH 0/2] Add s-exp support to Notmuch
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
70390: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=70390
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH 0/2] Add s-exp support to Notmuch
>
>
>
>
> Date: 
>
> Mon, 15 Apr 2024 08:19:10 +0100
>
>
>
>
> Dear All,
>
> On 2022-04-25⁰, support for S-expression-based queries was added to
> Notmuch (version 0.36). This is based on a C/C++ library called sfsexp¹.
>
> You can check whether your Notmuch was built with s-exp support with
> this command²:
>
> ,----
> | notmuch config get built_with.sexp_queries
> `----
>
> The Notmuch version currently packaged in Guix does not support s-exp
> queries.
>
> This patch micro-series is to:
>
> - Add sfsexp¹.
> - Update Notmuch to make use of sfsexp and to allow S-expression-based queries.
>
> Thanks, best wishes, Fabio.
>
>
> ⁰ 
> https://git.notmuchmail.org/git?p=notmuch;a=blob;f=NEWS;h=cf8107f26362431549dc410cb8379de5c10221f1;hb=HEAD#l165
> ¹ https://github.com/mjsottile/sfsexp
> ² https://notmuchmail.org/doc/latest/man7/notmuch-sexp-queries.html
>
>
> Fabio Natali (2):
>   gnu: Add sfsexp.
>   gnu: notmuch: Add sfsexp dependency.
>
>  gnu/packages/c.scm    | 22 ++++++++++++++++++++++
>  gnu/packages/mail.scm |  4 +++-
>  2 files changed, 25 insertions(+), 1 deletion(-)
>
>
> base-commit: e5dda412c2e28fb65a549824f492895e72c33813
> -- 
> 2.41.0
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: [bug#70390] QA review for 70390 Date: Mon, 13 May 2024 21:43:33 +0100 User-agent: mu4e 1.12.2; emacs 29.3

Nicolas Graves via Guix-patches via <guix-patches@gnu.org> writes:

> On 2024-05-13 10:42, Nicolas Graves wrote:
>
>> user guix
>> usertag 70390 + reviewed-looks-good
>> thanks
>>
>> Guix QA review form submission:
>>
>> git should be rewritten to git-minimal and inserted a few lines down
>> instead.
>
> And probably git-minimal/pinned, see https://issues.guix.gnu.org/70656
> for instance.
>
>> Otherwise LGTM.
>>
>> Items marked as checked: Lint warnings, Package builds, Commit messages, New 
>> package licenses, New package tests, New package synopsis and descriptions

Thanks both, I've tweaked the git input and pushed these patches to
master as b1de64812a0a9e30507fb1ea44611779149c32cc.

Chris

signature.asc
Description: PGP signature

--- End Message ---