--- Begin Message ---
|
Subject: |
[PATCH 0/4] Update power-profiles-daemon and add a service-type for it. |
|
Date: |
Thu, 18 Apr 2024 18:31:10 +0000 |
Hi Guix,
Here are a couple of patches that update the power-profiles-daemon to the
latest release and add a corresponding service for it which will make changing
power-profiles available in DEs like GNOME or via the cli tool.
I am not sure if some of the python dependencies should be normal inputs rather
than native inputs.
The package will now also build the shell completions, manpage, docs and skip
installing the systemd unit.
Also I was not sure if the gtk-docs should go to a seperate doc output but this
corresponds to ~0.2 MB so I didn't bother.
The daemon is supposed to be a systemd unit started via dbus but just
autostarting a similiar shepherd service seems fine as well and is what other
distros without systemd do (i.e gentoo or void linux).
I've also tried to patch the dbus service definiton to run the daemon directly
and it seems to work as well which would make the shepherd service obsolete. I
am not sure what the better solution is.
The systemd unit specifies a 'conflict' with other power-management services
like tlp but I don't think something similiar can be done for the shepherd
right now.
The service-type is a rather simple and has the following extensions:
shepherd: Run the daemon.
dbus: Make the name of the service available.
polkit: Allow normal users to change power profile.
profile: Make the cli tool available.
activation: Create a directory.
As this is my first time writing a service-type any feedback would be greatly
appreciated.
This would fix #69061.
Dariqq (4):
gnu: power-profiles-daemon: Update to 0.21.
gnu: power-profiles-daemon: Build gtk-docs.
gnu: power-profiles-daemon: Remove some (native) inputs.
gnu: services: Add power-profiles-daemon-service-type.
gnu/packages/freedesktop.scm | 45 ++++++++++++++++-------------
gnu/services/pm.scm | 56 +++++++++++++++++++++++++++++++++++-
2 files changed, 80 insertions(+), 21 deletions(-)
base-commit: 65e8472a4b6fc6f66871ba0dad518b7d4c63595e
--
2.41.0
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: [bug#70460] [PATCH v2 0/3] Update power-profiles-daemon and add a service-type for it. |
|
Date: |
Thu, 16 May 2024 07:55:39 +0100 |
|
User-agent: |
mu4e 1.12.2; emacs 29.3 |
Dariqq <dariqq@posteo.net> writes:
> Hi all,
>
> Here is v2 of the patches.
>
> I hope the added manual entry is ok as I don't have prior experience
> writing texinfo. I've added the note not to use tlp and p-p-d together
> there too.
>
> Also is there a better way to set the pythonpath to not include the
> packages in native-inputs? This decreases guix size of the package by
> 100 MB.
...
> Things that could still be improved:
> * The generated manpage looks horrible because python-argparse-manpage
> is outdated. I've tried updating it but ran into test errors.
> * Test timeout issues on qa? I am not sure what to do here as it is
> kind of hard for me to guess what an appropriate timeout window would
> be that would work.
>
>
> Dariqq (3):
> gnu: power-profiles-daemon: Update to 0.21.
> gnu: power-profiles-daemon: Build gtk-docs.
> gnu: services: Add power-profiles-daemon-service-type.
>
> doc/guix.texi | 40 +++++++++++++++++++++++++
> gnu/packages/freedesktop.scm | 56 +++++++++++++++++++++++------------
> gnu/services/pm.scm | 57 +++++++++++++++++++++++++++++++++++-
> 3 files changed, 134 insertions(+), 19 deletions(-)
Thanks both, these patches look good to me. I removed some tabs and
tweaked some indentation and pushed these to master as
d0ad4f557fc8b9d105877f2ef4de0ce12c5c9566.
Chris
signature.asc
Description: PGP signature
--- End Message ---