bug#71089: closed ([PATCH] import/elpa: Add proper file-name to origin.)

[GNU bug Tracking System]

Your message dated Wed, 22 May 2024 15:51:06 +0800
with message-id <87a5kinv2t.fsf@iscas.ac.cn>
and subject line Re: [bug#71089] [PATCH] import/elpa: Add proper file-name to 
origin.
has caused the debbugs.gnu.org bug report #71089,
regarding [PATCH] import/elpa: Add proper file-name to origin.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
71089: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=71089
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] import/elpa: Add proper file-name to origin.
>
>
>
>
> Date: 
>
> Tue, 21 May 2024 08:46:52 +0200
>
>
>
>
> This avoids the lint "the source file name should contain the package
> name" with generated packages.
>
> Change-Id: I61c81203d9f3cdd035e2b64a4c7a8d86d1f3dd50
> ---
>  guix/import/elpa.scm | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/guix/import/elpa.scm b/guix/import/elpa.scm
> index d1855b36986..46b6dc98a20 100644
> --- a/guix/import/elpa.scm
> +++ b/guix/import/elpa.scm
> @@ -250,6 +250,7 @@ (define ref
>         (uri (git-reference
>               (url ,url)
>               (commit ,commit)))
> +       (file-name (git-file-name name version))
>         (sha256
>          (base32
>           ,(bytevector->nix-base32-string
> -- 
> 2.41.0
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: [bug#71089] [PATCH] import/elpa: Add proper file-name to origin. Date: Wed, 22 May 2024 15:51:06 +0800 User-agent: mu4e 1.12.4; emacs 30.0.50

Nicolas Graves via Guix-patches via <guix-patches@gnu.org> writes:

> This avoids the lint "the source file name should contain the package
> name" with generated packages.
>
> Change-Id: I61c81203d9f3cdd035e2b64a4c7a8d86d1f3dd50
> ---
>  guix/import/elpa.scm | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/guix/import/elpa.scm b/guix/import/elpa.scm
> index d1855b36986..46b6dc98a20 100644
> --- a/guix/import/elpa.scm
> +++ b/guix/import/elpa.scm
> @@ -250,6 +250,7 @@ (define ref
>         (uri (git-reference
>               (url ,url)
>               (commit ,commit)))
> +       (file-name (git-file-name name version))
>         (sha256
>          (base32
>           ,(bytevector->nix-base32-string

push, see 
https://git.savannah.gnu.org/cgit/guix.git/commit/?id=6bcecb6898d0e205a705f3cfb4a3140f45dd7034

signature.asc
Description: PGP signature

--- End Message ---