bug#70715: closed ([PATCH 0/4] Change imported crate style.)

[GNU bug Tracking System]

Your message dated Mon, 03 Jun 2024 22:37:55 +0200
with message-id <87tti9ahjw.fsf@gnu.org>
and subject line Re: [bug#70715] [PATCH v2 0/3] Change imported crate style.
has caused the debbugs.gnu.org bug report #70715,
regarding [PATCH 0/4] Change imported crate style.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
70715: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=70715
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH 0/4] Change imported crate style.
>
>
>
>
> Date: 
>
> Thu,  2 May 2024 14:57:00 +0200
>
>
>
>
> Hello,
>
> Having created about 60 packages with the crate importer, I did it
> slightly faster than usual with this patch series applied.
>
> I would say 75% of the time the unindented #:cargo-development-inputs
> exceeded 72 characters.
>
> About 20% of the time a crate synopsis and description start with a
> proper noun (Rust) or an acronym (FFI). Adding 'This package provides '
> makes the description into more of a sentence, though sometimes an
> indefinite article is missing. I could also instead add a flag to 'guix
> import' for extending the description in this way.
>
> Cheers,
> Herman
>
> Herman Rimm (4):
>   guix: Indent cargo-development-inputs.
>   guix: Beautify crate importer synopses.
>   guix: Include a main verb in crate importer descriptions.
>   guix: End package descriptions with period.
>
>  guix/import/crate.scm | 12 ++++++++----
>  guix/import/utils.scm |  7 +++++++
>  guix/read-print.scm   |  1 +
>  3 files changed, 16 insertions(+), 4 deletions(-)
>
> -- 
> 2.41.0
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#70715] [PATCH v2 0/3] Change imported crate style.
>
>
>
>
> Date: 
>
> Mon, 03 Jun 2024 22:37:55 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13)
>
>
>
>
> Hi Herman,
>
> Herman Rimm <herman@rimm.ee> skribis:
>
> > I don't think indenting the #:cargo-development-inputs necessary;
> > I removed the first patch and will work on [bug#49531] instead.
>
> Yes, addressing #49531 would be great.
>
> >   guix: Beautify crate importer synopses.
> >   guix: Include a main verb in crate importer descriptions.
> >   guix: End package descriptions with period.
>
> Neat!  Applied after tweaking commit logs and making minor changes (see
> following messages).
>
> Thanks!
>
> Ludo’.
>
>
> --- End Message ---