bug#70148: closed ([PATCH] guix-install.sh: Add daemonize to requirements.)

[GNU bug Tracking System]

Your message dated Tue, 04 Jun 2024 12:11:41 +0200
with message-id <87zfs16mqq.fsf@gnu.org>
and subject line Re: [bug#70148] [PATCH v2] guix-install.sh: Add unique 
requirement for sysv init system
has caused the debbugs.gnu.org bug report #70148,
regarding [PATCH] guix-install.sh: Add daemonize to requirements.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
70148: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=70148
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] guix-install.sh: Add daemonize to requirements.
>
>
>
>
> Date: 
>
> Tue,  2 Apr 2024 12:14:16 -0400
>
>
>
>
> * etc/guix-install.sh (REQUIRE): Add daemonize to requirements list.
> Needed to spawn the Guix Daemon in guix-daemon.in
>
> Change-Id: I77c7f2bdd686bb023ecfa108a499c2eafbad1eb7
> ---
>
> Hi Guix. I noticed that in Debian WSL the guix daemon sysvinit service
> wouldn't start due to daemonize not being present. This patch should
> catch that issue sooner.
>
> Both openrc and sysvinit use guix-daemon.in so daemonize should be
> required regardless of the init system.
>
>  etc/guix-install.sh | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/etc/guix-install.sh b/etc/guix-install.sh
> index 982fb0a266..94ecb1d8f3 100755
> --- a/etc/guix-install.sh
> +++ b/etc/guix-install.sh
> @@ -56,6 +56,7 @@ set -eo pipefail
>  [ "$UID" -eq 0 ] || { echo "This script must be run as root."; exit 1; }
>  
>  REQUIRE=(
> +    "daemonize"
>      "dirname"
>      "readlink"
>      "wget"
>
> base-commit: d67e4f0f9b10c7ddac8fb0ca68cbf1d6ad0a6e5d
> -- 
> 2.41.0
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#70148] [PATCH v2] guix-install.sh: Add unique requirement for sysv init system
>
>
>
>
> Date: 
>
> Tue, 04 Jun 2024 12:11:41 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13)
>
>
>
>
> Hello,
>
> Richard Sent <richard@freakingpenguin.com> skribis:
>
> > Ludovic Courtès <ludo@gnu.org> writes:
> >
> >> ‘local’, [[, and arrays are probably Bash-specific.  However this is a
> >> #!/bin/sh script, and some systems such as Debian use Dash as /bin/sh.
> >> So I’m afraid the script would break on such systems.
> >>
> >> WDYT?  Do you think we can avoid those features?
>
> [...]
>
> > The script is already using all 3 of these constructs too.
>
> Oh right, I had completely overlooked that.  In that case my point is
> moot (it might be useful to not require Bash, but that’s a separate
> topic).
>
> Pushed as 40c6f708393885a2d28f847350e8f47beb11e745, thanks!
>
> Ludo’.
>
>
> --- End Message ---