--- Begin Message ---
|
Subject: |
30.0.50; [PATCH] Improve performance of buffered output in Eshell |
|
Date: |
Mon, 3 Jun 2024 22:36:29 -0700 |
In Eshell, if I run "time cat config.log" from my Emacs build directory,
it reports that it takes about 7.5s. It also doesn't show *any* output
until it's completely finished. With my attached patches, it now takes
about 0.6s and also shows the output iteratively, redisplaying
periodically so users can see that something is happening.
The other command most likely to be impacted by this is the built-in
version of "ls". When I run "ls -Al /usr/bin" on my system, I go from
2.1s before my patch to 1.2s after. Not as big an improvement, but still
noticeable, and it *feels* a lot faster too with the iterative redisplay.
I don't usually add a NEWS entry for perf improvements, but this one
seemed notable enough that I figured it was worth tooting my own horn. :)
0001-Be-more-efficient-when-buffering-output-in-Eshell.patch
Description: Text document
0002-Improve-implementations-of-some-Eshell-output-filter.patch
Description: Text document
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: bug#71355: 30.0.50; [PATCH] Improve performance of buffered output in Eshell |
|
Date: |
Sat, 8 Jun 2024 12:43:18 -0700 |
On 6/8/2024 12:33 AM, Stefan Kangas wrote:
Jim Porter <jporterbugs@gmail.com> writes:
Since it sounds like all the other concerns have been addressed, I'll
probably merge this in the next day or so. (This is the last non-bugfix
change I'd like to land for Eshell in Emacs 30.)
Sounds good to me.
I took one last look after sleeping on it, and everything seems correct
to me, so I've now merged this to the master branch as 15f515c7a37.
--- End Message ---