bug#71406: closed (30.0.50; string-edit signals error when user aborts and :abort-callback parameter nil)

[GNU bug Tracking System]

Your message dated Sat, 15 Jun 2024 13:42:34 +0300
with message-id <868qz6v65h.fsf@gnu.org>
and subject line Re: bug#71406: 30.0.50; string-edit signals error when user 
aborts and :abort-callback parameter nil
has caused the debbugs.gnu.org bug report #71406,
regarding 30.0.50; string-edit signals error when user aborts and 
:abort-callback parameter nil
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
71406: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=71406
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> 30.0.50; string-edit signals error when user aborts and :abort-callback parameter nil
>
>
>
>
> Date: 
>
> Thu, 06 Jun 2024 12:03:34 -0400
>
>
>
>
>
> 1. emacs -q
> 2. eval (string-edit "test" "" #'ignore)
> 3. In the "*edit string*" buffer eval string-edit-abort.
>
> The following error is signaled:
>
> Debugger entered--Lisp error: (void-variable 
> string-edit--abort-callback)
>  string-edit-abort()
>  funcall-interactively(string-edit-abort)
>  command-execute(string-edit-abort)
>
> Seeing as string-edit specifies this parameter as a &key, it 
> should either provide a default (#'ignore?) or error if the caller 
> does not provide an abort function (Though why specify it as a 
> keyword arg if it's mandatory?).
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#71406: 30.0.50; string-edit signals error when user aborts and :abort-callback parameter nil
>
>
>
>
> Date: 
>
> Sat, 15 Jun 2024 13:42:34 +0300
>
>
>
>
> > From: Nicholas Vollmer <nv@parenthetic.dev>
> > Cc: 71406@debbugs.gnu.org
> > Date: Mon, 10 Jun 2024 16:50:29 -0400
> > 
> > Eli Zaretskii <eliz@gnu.org> writes:
> > 
> > > Thanks, I fixed this with the patch below.
> > 
> > Makes sense. Works on my end, too.
>
> Thanks, I'm therefore closing this bug.
>
>
> --- End Message ---