bug#71204: closed ([PATCH 1/2] gnu: guix: Add imagemagick, perl and use full graphviz.)

[GNU bug Tracking System]

Your message dated Sun, 23 Jun 2024 22:58:53 -0400
with message-id <87cyo759n6.fsf@gmail.com>
and subject line Re: [bug#71204] [PATCH 1/2] gnu: guix: Add imagemagick, perl 
and use full graphviz.
has caused the debbugs.gnu.org bug report #71204,
regarding [PATCH 1/2] gnu: guix: Add imagemagick, perl and use full graphviz.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
71204: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=71204
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH 1/2] gnu: guix: Add imagemagick, perl and use full graphviz.
>
>
>
>
> Date: 
>
> Sun, 26 May 2024 04:26:16 +0000
>
>
>
>
> This makes it possible to run 'make distcheck' in a 'guix shell -D guix'
> environment.
>
> * gnu/packages/package-management.scm (guix)
> [native-inputs]: Replace graphviz-minimal with graphviz.  Add imagemagick and
> perl.
>
> Change-Id: Ie400c622d8fc77108df29c03e11f36159d6f6238
> ---
>  gnu/packages/package-management.scm | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/package-management.scm 
> b/gnu/packages/package-management.scm
> index 862de9f942..2f1434d5be 100644
> --- a/gnu/packages/package-management.scm
> +++ b/gnu/packages/package-management.scm
> @@ -490,8 +490,10 @@ (define-public guix
>                         ("automake" ,automake)
>                         ("gettext" ,gettext-minimal)
>                         ("texinfo" ,texinfo)
> -                       ("graphviz" ,graphviz-minimal)
> +                       ("graphviz" ,graphviz) ;non-minimal for PDF support
>                         ("font-ghostscript" ,font-ghostscript) ;fonts for 'dot'
> +                       ("imagemagick" ,imagemagick) ;for 'make dist'
> +                       ("perl" ,perl)               ;for 'make dist'
>                         ("help2man" ,help2man)
>                         ("po4a" ,po4a-minimal)))
>        (inputs
>
> base-commit: 77771036f0970083c146b709d792d128f4235125
> -- 
> 2.41.0
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#71204] [PATCH 1/2] gnu: guix: Add imagemagick, perl and use full graphviz.
>
>
>
>
> Date: 
>
> Sun, 23 Jun 2024 22:58:53 -0400
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13)
>
>
>
>
> Hi,
>
> Zheng Junjie <zhengjunjie@iscas.ac.cn> writes:
>
> > Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
> >
> >> Hi Zheng,
> >>
> >> Zheng Junjie <zhengjunjie@iscas.ac.cn> writes:
> >>
> >>> Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
> >>>
> >>>> This makes it possible to run 'make distcheck' in a 'guix shell -D guix'
> >>
> >>> I think maybe should add them to manifest.scm? And just 'guix shell' or
> >>> 'guix shell -m manifest.scm'?
> >>
> >> I think it's nice that 'make distcheck' works out of the box, even for
> >> 'guix shell -D guix ...'.  According to 'guix size' the
> >> new $GUIX_ENVIRONMENT produced with the added inputs do not add any
> >
> > ok, LGTM. 
>
> Applied, thanks for taking a look!
>
> -- 
> Thanks,
> Maxim
>
>
> --- End Message ---