emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#74033: closed (31.0.50; [PATCH] Improve accuracy of Eshell globbing


From: GNU bug Tracking System
Subject: bug#74033: closed (31.0.50; [PATCH] Improve accuracy of Eshell globbing syntax)
Date: Fri, 01 Nov 2024 05:42:03 +0000

Your message dated Thu, 31 Oct 2024 22:40:06 -0700
with message-id <eed84993-0a41-06ee-9673-5f4c5f83ff1c@gmail.com>
and subject line Re: bug#74033: 31.0.50; [PATCH] Improve accuracy of Eshell 
globbing syntax
has caused the debbugs.gnu.org bug report #74033,
regarding 31.0.50; [PATCH] Improve accuracy of Eshell globbing syntax
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
74033: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=74033
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
--- Begin Message --- Subject: 31.0.50; [PATCH] Improve accuracy of Eshell globbing syntax Date: Sat, 26 Oct 2024 15:08:10 -0700 I've been tracking down a few issues with how Eshell parses its globs. For example:

  ~ $ echo **/
  # Prints all subdirectories of the current dir (good)
  ~ $ echo '**/'
  **/  # Prints the literal string (also good)
  ~ $ echo \**/
  # Prints all subdirectories (bad!)

There are a few reasons this happens but one of the things that makes this code more brittle is that Eshell defaults to treating characters as globs, and you have to opt out via an 'escape' text property. By inverting this logic, and proactively marking globbing characters with 'eshell-glob-char', it now means that all the rules for determining which characters are globs and which are literals is in em-glob.el, so it should be harder to break in the future.

Attachment: 0001-Improve-correctness-of-Eshell-globs-when-using-escap.patch
Description: Text document


--- End Message ---
--- Begin Message --- Subject: Re: bug#74033: 31.0.50; [PATCH] Improve accuracy of Eshell globbing syntax Date: Thu, 31 Oct 2024 22:40:06 -0700
On 10/26/2024 3:08 PM, Jim Porter wrote:
I've been tracking down a few issues with how Eshell parses its globs.

Now merged to the master branch as 9682d385c10, so closing this bug.


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]