bug#74112: closed ([PATCH] Fix determinism issue in guix package)

[GNU bug Tracking System]

Your message dated Tue, 05 Nov 2024 23:25:29 +0800
with message-id <87ed3pzora.wl-hako@ultrarare.space>
and subject line Re: [bug#74112] bug#74204: Guix is not reproducible
has caused the debbugs.gnu.org bug report #74112,
regarding [PATCH] Fix determinism issue in guix package
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
74112: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=74112
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: [PATCH] Fix determinism issue in guix package Date: Wed, 30 Oct 2024 19:06:57 +0100

I've recently noticed that `guix challenge guix` returns different hashes for 
each substitute server and also every build with `guix build --no-grafts guix` 
fails.
Running `guix build --no-grafts guix --cores=1` seems to reliably produce the 
same hash though. As someone pointed out on XMPP, Guile seems to have issues 
with parallel builds so this patch disables them for the guix package.

I think this has high importance because the main guix package should be 
reproducible in order to trust the whole chain of packages.

v1-0001-gnu-guix-Fix-determinism-issue.patch
Description: Text document

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#74112] bug#74204: Guix is not reproducible
>
>
>
>
> Date: 
>
> Tue, 05 Nov 2024 23:25:29 +0800
>
>
>
>
> Hello again,
>
> On Tue, 05 Nov 2024 18:31:04 +0800,
> Hilton Chain via Guix-patches via wrote:
> >
> > Hi Jakob,
> >
> > On Tue, 05 Nov 2024 02:38:34 +0800,
> > Jakob Kirsch via Bug reports for GNU Guix wrote:
> > >
> > > I've recently noticed that `guix challenge guix` fails since guix isn't
> > > reproducible at the moment. As someone pointed out on XMPP, this is due to
> > > parallelism issues with Guile so running `guix build guix --no-grafts
> > > --cores=1 --check` reliably produces the same output.
> > >
> > > I've sent a simple patch in #74112 to address this and I think this is
> > > important since the main guix package should definitely be reproducible so 
> > > it
> > > can be trusted.
> >
> > I can confirm the reproducibility issue.
> >
> > I have two x86_64-linux machines building guix to verify the fix, I'll apply
> > your patch once they produce matching outputs.
>
> Took me quite a while to build 5 rounds. :)
>
> --8<---------------cut here---------------start------------->8---
> $ guix hash --serializer=nar 
> /gnu/store/fs7x07jfn7igpkwv3alrs9by21q70y13-guix-1.4.0-26.5ab3c4c
> 0kh87wb4qn97kwzrf4igal71cjvv143j6jr2y3dwfzcy1madj1ll
> --8<---------------cut here---------------end--------------->8---
>
> Applied #74112 as 4c56d0cccdc44e12484b26332715f54768738c5f, thanks!
>
>
> --- End Message ---