bug#73862: closed ([PATCH] Add `header-line-active` and `header-line-inactive` faces.)

[GNU bug Tracking System]

Your message dated Sat, 16 Nov 2024 16:11:05 +0200
with message-id <867c93gtfq.fsf@gnu.org>
and subject line Re: bug#73862: [PATCH] Add `header-line-active` and 
`header-line-inactive` faces.
has caused the debbugs.gnu.org bug report #73862,
regarding [PATCH] Add `header-line-active` and `header-line-inactive` faces.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
73862: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=73862
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: [PATCH] Add `header-line-active` and `header-line-inactive` faces. Date: Fri, 18 Oct 2024 05:56:32 -0700

Tags: patch

Got a quick feature request.

Over the years I've put more and more information into the header line, and at 
some point I wanted to get that quick visual indicator of selected vs 
non-selected windows when I glanced at the header as I already got from the 
mode line.

This was surprisingly hard to achieve!  For a few years I used an ugly 
`buffer-list-update-hook` hack.  Then a few months ago I got adventurous and 
found that it actually wasn't as hard as I'd feared to hack these into the C 
source.

The new faces both inherit from the current `header-line` face, so there 
shouldn't be any visible impact if users don't customize the new faces.  For 
cases like mine it's easy to customize header-line-inactive to inherit from 
mode-line-inactive.

Thanks in advance for your attention and feedback,

Trevor


In GNU Emacs 29.4 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.43,
cairo version 1.18.0)
Repository revision: a92669f7ae7de3172cf883d15af9d7bb9bda7dd9
Repository branch: main
System Description: Arch Linux

Configured using:
 'configure --with-pgtk --with-native-compilation=aot --sysconfdir=/etc
 --prefix=/usr --libexecdir=/usr/lib --with-tree-sitter
 --localstatedir=/var --with-cairo --disable-build-details
 --with-harfbuzz --with-libsystemd --with-modules 'CFLAGS=-march=x86-64
 -mtune=generic -O2 -pipe -fno-plt -fexceptions -Wp,-D_FORTIFY_SOURCE=3
 -Wformat -Werror=format-security -fstack-clash-protection
 -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -g
 -ffile-prefix-map=/home/trevor/pkgbuilds/abs/emacs/src=/usr/src/debug/emacs
 -flto=auto' 'LDFLAGS=-Wl,-O1 -Wl,--sort-common -Wl,--as-needed
 -Wl,-z,relro -Wl,-z,now -Wl,-z,pack-relative-relocs -flto=auto'
 'CXXFLAGS=-march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions
 -Wp,-D_FORTIFY_SOURCE=3 -Wformat -Werror=format-security
 -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer
 -mno-omit-leaf-frame-pointer -Wp,-D_GLIBCXX_ASSERTIONS -g
 -ffile-prefix-map=/home/trevor/pkgbuilds/abs/emacs/src=/usr/src/debug/emacs
 -flto=auto''

0001-Add-new-header-line-active-and-header-line-inactive-.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#73862: [PATCH] Add `header-line-active` and `header-line-inactive` faces.
>
>
>
>
> Date: 
>
> Sat, 16 Nov 2024 16:11:05 +0200
>
>
>
>
> > From: Trevor Murphy <trevor.m.murphy@gmail.com>
> > Date: Sun, 10 Nov 2024 22:11:30 -0800
> > Cc: 73862@debbugs.gnu.org
> > 
> > Hi!  Thanks for your patience, attached please find the updated patch.  I've 
> > added documentation and a
> > NEWS entry modeled off of similar commits.  
> > 
> > When I put together the original patch I included a non-trivial value for the 
> > default header-line-inactive
> > (copied from mode-line-inactive) as a visual indicator for the new face.  
> > Happy to take it out.  In this updated
> > patch, header-line-inactive just inherits from header-line.  I tested by 
> > looking at selected and not-selected
> > Info buffers with emacs -Q both patched and unpatched, in both graphical and 
> > terminal.
>
> Thanks, installed on the master branch, and closing the bug.
>
>
> --- End Message ---