Re: Inefficient code in reftex-index.el

[David Kastrup]

address@hidden (Kim F. Storm) writes:

> In any case, I didn't find any code which actually uses the REUSE
> form of match-data, so that feature is pretty obscure already, so I
> think we should just keep the original behavior of the REUSE arg.

Look at replace-match-data in replace.el...

I think it was me that did that piece of prescient paranoia.

>>> In any case, to me, the match-data interface should not be
>>> considered a user-level feature _at all_.
>>
>> There is no other interface into the number of accessible match
>> strings (which might be nil) rather than
>> (/ (length (match-data t)) 2).
>
> That's still pretty inefficient -- I suggest that we introduce a new
> function `match-count' to return that number.

No objection here.  No idea whether match-size would be more
appropriate.  The C code is not really helpful deciding about that
since it uses search_regs.num_regs and that is not suggestive of any
sensible Lisp name.

-- 
David Kastrup, Kriemhildstr. 15, 44793 Bochum