Re: foreground menu bug

[Richard M. Stallman]

    Also, what does a disabled menu item tell the user? He might not
    understand that it is because font lock is enabled. He might wonder if
    he is doing something wrong seeing that menu item disabled.

This makes no sense.  Menu items are disabled when they are not
applicable; users know that.

    Assuming the user notices that we disabled the menu item, your fix
    might work. What about users who use M-x apropos or similar to find
    commands and then used enter the commands with M-x, how would they
    know that this comment is currently "disabled", or not meant to be
    used?

It might be a good idea to do that in addition.  What do you think
of this patch?

*** facemenu.el 27 Jun 2005 16:24:59 -0400      1.79
--- facemenu.el 27 Jun 2005 22:24:24 -0400      
***************
*** 611,617 ****
                                                  self-insert-face
                                                (list self-insert-face)))
                                 face)
!             self-insert-face-command this-command)))))
  
  (defun facemenu-active-faces (face-list &optional frame)
    "Return from FACE-LIST those faces that would be used for display.
--- 611,619 ----
                                                  self-insert-face
                                                (list self-insert-face)))
                                 face)
!             self-insert-face-command this-command))))
!   (unless (facemenu-enable-faces-p)
!     (message "Font-lock mode will override any faces you set in this 
buffer")))
  
  (defun facemenu-active-faces (face-list &optional frame)
    "Return from FACE-LIST those faces that would be used for display.