Re: delete-process bug

[Michaël Cadilhac]

address@hidden (Kim F. Storm) writes:

> address@hidden (Michaël Cadilhac) writes:
>
>> The whole patch follows:
>
> Thanks.  Installed.

Thanks!

Now that this bug is fixed, Agustin, can you check (a third time) if
the first patch is OK? (Copy of the message follows)

address@hidden (Michaël Cadilhac) writes:

> I was wondering why ispell-kill-process took so much time to
> execute.
>
> This function does the following:
>   - Send EOF to ispell,
>   - Read its output if there is, timeout to 1 sec,
>   - Kill the process if it's still not,
>   - Wait for it to be really killed (sleeping for 0.25 sec between checks).

Oh, and BTW, why is the wait_for_termination function not provided to
the user?

> I don't want to be ... rude, I'm really a pacifist actually, but why
> not just delete-process it ?

> I propose the following change:

Index: lisp/ChangeLog
===================================================================
RCS file: /sources/emacs/emacs/lisp/ChangeLog,v
retrieving revision 1.9586
diff -c -B -b -r1.9586 ChangeLog
*** lisp/ChangeLog      23 May 2006 11:23:25 -0000      1.9586
--- lisp/ChangeLog      23 May 2006 18:17:41 -0000
***************
*** 1,3 ****
--- 1,9 ----
+ 2006-05-23  Michaël Cadilhac  <address@hidden>
+ 
+       * textmodes/ispell.el (ispell-kill-ispell): If ispell has been
+       launched asynchronously, delete its process instead of being
+       cool.
+ 
  2006-05-23  Thien-Thi Nguyen  <address@hidden>
  
        * emacs-lisp/ewoc.el (ewoc-delete): New function.
Index: lisp/textmodes/ispell.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/textmodes/ispell.el,v
retrieving revision 1.199
diff -c -B -b -r1.199 ispell.el
*** lisp/textmodes/ispell.el    21 May 2006 20:25:43 -0000      1.199
--- lisp/textmodes/ispell.el    23 May 2006 18:17:41 -0000
***************
*** 2572,2586 ****
        (or no-error
          (error "There is no ispell process running!"))
      (if ispell-async-processp
!       (progn
!         (process-send-eof ispell-process)
!         (if (eq (ispell-process-status) 'run)
!             (ispell-accept-output 1))
!         (if (eq (ispell-process-status) 'run)
!             (kill-process ispell-process))
!         (while (not (or (eq (ispell-process-status) 'exit)
!                         (eq (ispell-process-status) 'signal)))
!           (sleep-for 0.25)))
        ;; synchronous processes
        (ispell-send-string "\n")               ; make sure side effects 
occurred.
        (kill-buffer ispell-output-buffer)
--- 2572,2578 ----
        (or no-error
          (error "There is no ispell process running!"))
      (if ispell-async-processp
!       (delete-process ispell-process)
        ;; synchronous processes
        (ispell-send-string "\n")               ; make sure side effects 
occurred.
        (kill-buffer ispell-output-buffer)


-- 
 |      Michaël `Micha' Cadilhac   |  Mieux vaut se taire                   |
 |         Epita/LRDE Promo 2007   |   Que de parler trop fort.             |
 | http://www.lrde.org/~cadilh_m   |           -- As de trèfle              |
 `--  -   JID: address@hidden --'                                   -  --'

pgp43xAnt1y0t.pgp
Description: PGP signature