Re: Patch: Add call graph to elp.el

[Michael Olson]

Christian Ohler <address@hidden> writes:

> The attached patch makes elp.el record and display call graph
> information.  This makes the profiler much more useful.

Just a few nitpicks before reviewing more in-depth.

> Christian.
> --- elp.el    28 Jan 2008 22:48:53 +0100      1.43
> +++ elp.el    08 Feb 2008 21:58:18 +0100      
> @@ -126,6 +126,8 @@
>
>  ;;; Code:
>
> +(require 'cl)
> +

Should be:

(eval-when-compile (require 'cl))

> @@ -245,7 +262,7 @@
>    ;; definition.
>    (elp-restore-function funsym)
>    (let* ((funguts (symbol-function funsym))
> -      (infovec (vector 0 0 funguts))
> +         (infovec (vector 0 0 funguts (list) (list)))
>        (newguts '(lambda (&rest args))))
>      ;; we cannot profile macros
>      (and (eq (car-safe funguts) 'macro)

Use a tab instead of a space at the beginning, because that is what is
done in the rest of the file.

> @@ -386,6 +403,8 @@
>      (aset info 0 0)                  ;reset call counter
>      (aset info 1 0.0)                        ;reset total time
>      ;; don't muck with aref 2 as that is the old symbol definition
> +    (aset info 3 (list))             ;reset children
> +    (aset info 4 (list))                ;reset parents
>      ))

Tab instead of space between code and comment.

-- 
|       Michael Olson  |  FSF Associate Member #652     |
| http://mwolson.org/  |  Hobbies: Lisp, HCoop          |
| Projects: Emacs, Muse, ERC, EMMS, ErBot, DVC, Planner |
`-------------------------------------------------------'

pgpLyUR77v30Y.pgp
Description: PGP signature