[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: process-attributes patch
From: |
Eli Zaretskii |
Subject: |
Re: process-attributes patch |
Date: |
Tue, 03 Feb 2009 21:50:08 +0200 |
> From: Miles Bader <address@hidden>
> Date: Tue, 03 Feb 2009 19:13:00 +0900
>
> (2) Add a "process_pid" function in process.c that contains the
> process->pid mapping code which used to be in Fsignal_process.
> process_pid also accepts straight process-ids.
How many copies of this function did you add to process.c? It looks
like you added only one, while I think you need 2: one each for the
#ifdef subprocess branch and the #else branch.
> (4) Rename Fsystem_process_attributes to Fprocess_attributes, and have
> it call process_pid to convert a process object to a pid.
These are already documented in the ELisp reference manual, so the
docs need to be updated as well.