[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Why was diary-fancy-display-mode conditionalized?
From: |
Stephen Berman |
Subject: |
Why was diary-fancy-display-mode conditionalized? |
Date: |
Sun, 20 Sep 2009 21:06:13 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) |
As a result of this change:
2009-09-04 Glenn Morris <address@hidden>
[...]
* calendar/diary-lib.el (diary-fancy-display): Only switch modes if
necessary.
diary-fancy-display-mode-hook is only run when there is no live buffer
whose major mode is diary-fancy-display-mode; i.e., in effect, when
there is no fancy diary buffer. Previously the hook was run
unconditionally. Since calling diary-fancy-display when there is a live
fancy diary buffer erases and rewrites the buffer, but does not change
its major mode, this change means that, in this circumstance, any
functions in diary-fancy-display-mode-hook will not be called, which
can, e.g., result in a surprising change in the appearance of the fancy
diary buffer (I have such a function in diary-fancy-display-mode-hook in
my init file and was a victim of such surprise). This seems like a bug
to me, and I think the simplest fix is to revert the change; or does it
fix some other problem? If so, then how can the failure to run
diary-fancy-display-mode-hook be repaired?
Steve Berman
- Why was diary-fancy-display-mode conditionalized?,
Stephen Berman <=