[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] trivial patch, jumping cursor in term
From: |
Stefan Monnier |
Subject: |
Re: [PATCH] trivial patch, jumping cursor in term |
Date: |
Wed, 23 Sep 2009 22:15:22 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) |
>>>>> "Ivan" == Ivan Kanis <address@hidden> writes:
> Hello Dan,
> Here are the steps to reproduce the bug:
> M-x term
> C-x 2
> Input a character
The C-x 2 doesn't do anything here, so I don't know how to reproduce
your problem.
> You'll see the cursor move to the top left when it shouldn't. I have
> tracked the problem to the following call stack.
> term-emulate-terminal
> term-check-size
> term-set-scroll-region
> term-set-scroll-region
> The cursor should move when receiving ESC [ R, so I've added a parameter
> to term-set-scroll-region which will move the cursor if set to t.
> Could you, please, apply the patch?
I've installed the patch below instead. Can you confirm it works as well?
Stefan
--- term.el.~1.120.~ 2009-09-23 22:02:59.000000000 -0400
+++ term.el 2009-09-23 22:09:37.000000000 -0400
@@ -3369,7 +3369,8 @@
((eq char ?r)
(term-set-scroll-region
(1- term-terminal-previous-parameter)
- (1- term-terminal-parameter)))
+ (1- term-terminal-parameter))
+ (term-goto 0 0))
(t)))
(defun term-set-scroll-region (top bottom)
@@ -3389,8 +3390,7 @@
(or (term-using-alternate-sub-buffer)
(not (and (= term-scroll-start 0)
(= term-scroll-end term-height)))))
- (term-move-columns (- (term-current-column)))
- (term-goto 0 0))
+ (term-move-columns (- (term-current-column))))
;; (defun term-switch-to-alternate-sub-buffer (set)
;; ;; If asked to switch to (from) the alternate sub-buffer, and already
(not)
- [PATCH] trivial patch, jumping cursor in term, Ivan Kanis, 2009/09/23
- Re: [PATCH] trivial patch, jumping cursor in term, Dan Nicolaescu, 2009/09/23
- Re: [PATCH] trivial patch, jumping cursor in term,
Stefan Monnier <=
- Re: [PATCH] trivial patch, jumping cursor in term, Ivan Kanis, 2009/09/24
- Re: [PATCH] trivial patch, jumping cursor in term, Stefan Monnier, 2009/09/24
- Re: [PATCH] trivial patch, jumping cursor in term, Dan Nicolaescu, 2009/09/24
- Re: [PATCH] trivial patch, jumping cursor in term, Ivan Kanis, 2009/09/25
- Re: [PATCH] trivial patch, jumping cursor in term, Stefan Monnier, 2009/09/25
- Re: [PATCH] trivial patch, jumping cursor in term, Ivan Kanis, 2009/09/28