[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Commit netiquette.
From: |
Óscar Fuentes |
Subject: |
Re: Commit netiquette. |
Date: |
Thu, 18 Feb 2010 16:40:13 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1.92 (gnu/linux) |
"Alfred M. Szmidt" <address@hidden> writes:
> The Committer used the full Changelog entry as the commit message, so on
> interfaces that just shows the first line of the commit (like the
> emacs-diffs mailing list or the output of `bzr log --short' or `qlog')
> you see
>
> 2010-02-17 Mark A. Hershberger <address@hidden>
>
> which is hardly indicative of the change.
>
> This seems more of a short comming in `bzr log --short' than in the
> way one writes commit messages. A commit message is more than a
> single line.
This is like saying that "Subject" fields on e-mail messages are of
little use, that one always ought to look at the body of the message
before deciding if it is an interesting one.
> And the purpose of a change is always more suitable in the actual
> code as a comment.
Sure, but describing the purpose on the commit message is useful too,
mostly when the change is not circumscribed to a single point on one
file. Very handy for using with `annotate'.
On this respect I find changelog entries as a lame way of documenting
changes. Most of the time a changelog does not give more information
than what I quickly get combining `log' and `annotate', except when the
changelog entry documents the purpose of the change (not only *what*
changed) but this rarely happens. On projects that extensively use the
commit messages for documenting changes, using `log' and `annotate' is a
great learning tool when you are getting familiar with the code base.
- Re: Commit netiquette., (continued)
- Re: Commit netiquette., Alfred M. Szmidt, 2010/02/23
- Re: Commit netiquette., Juanma Barranquero, 2010/02/20
- Re: Commit netiquette., Alfred M. Szmidt, 2010/02/23
- Re: Commit netiquette., Juanma Barranquero, 2010/02/23
- Re: Commit netiquette., David Kastrup, 2010/02/23
- Re: Commit netiquette., Juanma Barranquero, 2010/02/23
Re: Commit netiquette.,
Óscar Fuentes <=
Re: Commit netiquette., Miles Bader, 2010/02/19
Re: Commit netiquette., Mark A. Hershberger, 2010/02/18