Re: attribute warn_unused_result

[Paul Eggert]

On 02/05/2011 08:07 PM, Eli Zaretskii wrote:
> MS-Windows already works with lib/ignore-value.h (your change in
> sysdep.c already used it).  So there's no need to use #ifndef DOS_NT
> in this case.

I don't see how the following patch could possibly work on Windows.
Although it would compile, surely it would break things badly if
the call to chdir () fails on Windows.  Have you tested it for
that case?

=== modified file 'src/sysdep.c'
--- src/sysdep.c        2011-02-06 01:25:41 +0000                               
+++ src/sysdep.c        2011-02-06 06:57:13 +0000                               
@@ -550,10 +550,8 @@ sys_subshell (void)
       /* Use our buffer's default directory for the subshell.  */              
       if (str && chdir ((char *) str) != 0)                                    
        {                                                                       
-#ifndef DOS_NT                                                                 
          ignore_value (write (1, "Can't chdir\n", 12));                        
          _exit (1);                                                            
-#endif                                                                         
        }                                                                       
                                                                                
       close_process_descs ();  /* Close Emacs's pipes/ptys */