Re: [PATCH] minibuffer issue with eshell-command

[Thierry Volpiatto]

Stefan Monnier <address@hidden> writes:

>>> When eshell-command start, it set eshell-mode in all minibuffers:
>>> ;(add-hook 'minibuffer-setup-hook 'eshell-mode)
>>> So when running another minibuffer, while eshell-command is started,
>>> it enable eshell-mode in this one, which is wrong.
>>> This patch fix this:
>
>> Any objections to push this on trunk?
>
> That looks OK, except that I think the add-hooks should be moved to the
> setup-hook function where they can be made to only apply locally (and
> I guess at that point you can get rid of the remove-hooks).
Right.
I have already commited this, i will modify tomorrow.

-- 
 𝕋𝕙𝕚𝕖𝕣𝕣𝕪
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997