[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/4] Refactor window-system configuration
From: |
Dan Nicolaescu |
Subject: |
Re: [PATCH 2/4] Refactor window-system configuration |
Date: |
Thu, 29 Dec 2011 18:05:44 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) |
Daniel Colascione <address@hidden> writes:
> On 12/29/11 2:43 PM, Dan Nicolaescu wrote:
>> Daniel Colascione <address@hidden> writes:
>>
>>> On 12/29/11 2:21 PM, Dan Nicolaescu wrote:
>>>> We don't use something like "#include TERM_HEADER" in any other place,
>>>> it you really want to consolidate this stuff, creating a new header
>>>> file to include seems better.
>>>
>>> There's a first time for everything, and besides: other projects have
>>
>> Why add another wrinkle when we have perfectly working solutions already?
>
> We don't have a working solution. We have a mess, and we're trying to
> clean it up. Sure, we don't have header constants right now, but we
> don't have any pure-dispatch headers either.
>
> I suppose we disagree on what counts as a wrinkle. In my mind, it's
> simpler for config.h to just tell code what header to include than to
> create (and maintain) a header file that consists solely of ifdefs and
> more includes.
There's a lot more emacs contributors that are fluent in C than
contributors fluent with autoconf. Why not cater to the majority?
- Re: [PATCH 4/4] Fix emacsclient to work with cygw32, (continued)
[PATCH 2/4] Refactor window-system configuration, Daniel Colascione, 2011/12/29
- Re: [PATCH 2/4] Refactor window-system configuration, Dan Nicolaescu, 2011/12/29
- Re: [PATCH 2/4] Refactor window-system configuration, Daniel Colascione, 2011/12/29
- Re: [PATCH 2/4] Refactor window-system configuration, Dan Nicolaescu, 2011/12/29
- Re: [PATCH 2/4] Refactor window-system configuration, Daniel Colascione, 2011/12/29
- Re: [PATCH 2/4] Refactor window-system configuration,
Dan Nicolaescu <=
- Re: [PATCH 2/4] Refactor window-system configuration, Daniel Colascione, 2011/12/29
- Re: [PATCH 2/4] Refactor window-system configuration, Eli Zaretskii, 2011/12/30
- Re: [PATCH 2/4] Refactor window-system configuration, Daniel Colascione, 2011/12/30
- Re: [PATCH 2/4] Refactor window-system configuration, Eli Zaretskii, 2011/12/30
Re: [PATCH 2/4] Refactor window-system configuration, Eli Zaretskii, 2011/12/30
Re: [PATCH 2/4] Refactor window-system configuration, Daniel Colascione, 2011/12/30
Re: [PATCH 2/4] Refactor window-system configuration, Eli Zaretskii, 2011/12/30
Re: [PATCH 2/4] Refactor window-system configuration, Daniel Colascione, 2011/12/30
Re: [PATCH 2/4] Refactor window-system configuration, Stefan Monnier, 2011/12/31
Re: [PATCH 2/4] Refactor window-system configuration, Stefan Monnier, 2011/12/30