[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Proposal: 'struct window' cleanup
From: |
Stefan Monnier |
Subject: |
Re: Proposal: 'struct window' cleanup |
Date: |
Mon, 21 May 2012 23:30:58 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) |
> + XWINDOW (selected_window)->start_at_line_beg_p = !NILP (Fbolp ());
I generally like the idea. But please don't use "_p" suffixes
for variables. The "p" stands for "predicate" and a predicate is a kind
of function, so that's not the right way to say that something is
a boolean value.
And as someone else mentioned, `dedicated' can take more values than just
t and nil, so it's not a candidate for the rewrite you suggest.
Stefan
- Proposal: 'struct window' cleanup, Dmitry Antipov, 2012/05/21
- Re: Proposal: 'struct window' cleanup, Davis Herring, 2012/05/21
- Re: Proposal: 'struct window' cleanup,
Stefan Monnier <=
- Re: Proposal: 'struct window' cleanup, Dmitry Antipov, 2012/05/22
- Re: Proposal: 'struct window' cleanup, Thien-Thi Nguyen, 2012/05/22
- Re: Proposal: 'struct window' cleanup, Stefan Monnier, 2012/05/22
- Re: Proposal: 'struct window' cleanup, Dmitry Antipov, 2012/05/23
- Re: Proposal: 'struct window' cleanup, Stefan Monnier, 2012/05/23
- Re: Proposal: 'struct window' cleanup, Dmitry Antipov, 2012/05/31
- Re: Proposal: 'struct window' cleanup, Eli Zaretskii, 2012/05/22