|
From: | Stefan Monnier |
Subject: | Re: [Emacs-diffs] master b7f83ad: Prefer memset to repeatedly assigning Qnil |
Date: | Wed, 21 Jan 2015 10:31:26 -0500 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) |
>> We don't need to keep the code for the "Qnil!=0" case > In that case I jumped the gun by adding that code. I just now removed it. >> But if we only consciously rely on Qnil==0 in a few special places > To help identify these I put 'verify (NIL_IS_ZERO)' in each such place > I know about (there are a half dozen). Can you try and bring most of those cases together in a .h file (presumably lisp.h)? I suggest to rename memsetnil to memset_zero_and_nil and to use it at those places where we set to nil as well as those places where we set a mix of Lisp_Objects and other fields to zeros and nils. Stefan
[Prev in Thread] | Current Thread | [Next in Thread] |