[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Reporting Lisp errors in dynamic modules
From: |
Eli Zaretskii |
Subject: |
Re: Reporting Lisp errors in dynamic modules |
Date: |
Fri, 27 Nov 2015 16:50:10 +0200 |
> Date: Fri, 27 Nov 2015 13:49:39 +0100
> From: Aurélien Aptel <address@hidden>
> Cc: Emacs development discussions <address@hidden>, Ted Zlatanov
> <address@hidden>,
> Daniel Colascione <address@hidden>, Philipp Stephani <address@hidden>
>
> On Fri, Nov 27, 2015 at 12:46 PM, Eli Zaretskii <address@hidden> wrote:
> >> It's an implementation detail and cannot be used safely by Lisp users.
> >> The danger of using it is it can make core Emacs crash.
> >
> > How can it cause Emacs to crash? Can you show a specific scenario?
> > We should be able to prevent that.
>
> You cannot allocate a valid struct module_fun_env embedded in a
> save_value from Lisp (first expected argument of 'module-call').
> Therefore any call to 'module-call' from Lisp is invalid.
We could easily detect that, and signal an error, couldn't we?
> It's an implementation detail and shouldn't be used directly by
> users.
I didn't want to let users use it. I want users to see a backtrace as
close to what they are used to as possible. Please help me improve
the backtrace.
> >> Also, unrelated but can I be added to the savannah emacs group? My
> >> savannah account is aaptel.
> > Please apply, and please explain your interests.
>
> I already signed the copyright assignment papers few years ago. I've
> already contributed a few things here and there (underwave support)
> and finally I initiated and spent most of a year working on this
> dynamic module feature, along with Philip Stephani. Is there anything
> else I should do?
No, I meant apply for membership on Savannah. Sorry if that was
unclear.