Re: fix for bug#29935 copyright-update inserts year at random places

[Eli Zaretskii]

> From: Stephen Leake <address@hidden>
> Date: Mon, 01 Jan 2018 17:29:27 -0600
> 
> Ok to commit to emacs-26?

How important is it to have this in Emacs 26?

> +  (let ((copyright-end (point)))
> +    (setq copyright-current-year (format-time-string "%Y"))
> +    (unless (string= (buffer-substring (- (match-end 3) 2) (match-end 3))
> +                  (substring copyright-current-year -2))
> +      (if (or noquery
> +           (save-window-excursion
> +             ;; Fixes some point-moving oddness (bug#2209, bug#29935).
> +             (save-excursion
> +               (switch-to-buffer (current-buffer))
> +                  ;; Ensure the copyright line is displayed.
> +                  (goto-char copyright-end)
> +               (y-or-n-p (if replace
> +                             (concat "Replace copyright year(s) by "
> +                                     copyright-current-year "? ")
> +                           (concat "Add " copyright-current-year
> +                                   " to copyright? "))))))

Why does this need to use save-window-excursion?  AFAIU, that's the
root cause of the problem, so did you try replacing it with equivalent
code that uses other facilities for the same purpose?

Thanks.