Re: auto-revert error on macOS when auto-revert-use-notify is t

[Alan Third]

On Sat, Jan 20, 2018 at 04:34:06PM +0100, Michael Albinus wrote:
> 
> I've pushed a patch to the master branch. It recreates a file
> notification in autorevert, if a file was deleted and recreated
> afterwards.
> 
> Since autorevert watches directories, the solution was simpler than
> expected. The `create' event for the file from the directory is a
> perfect trigger.
> 
> Could you, pls, check whether it works for you? I have extended the
> `auto-revert-test02-auto-revert-deleted-file', which runs OK in my
> environment. Testing on macOS (kqueue) is not possible for me.

Hi Michael,

The autorevert test fails on macOS for me:

Running 8 tests (2018-01-21 20:06:51+0000)
Library: `kqueue'
   passed  1/8  file-notify-test00-availability
   passed  2/8  file-notify-test01-add-watch
   passed  3/8  file-notify-test02-rm-watch
   passed  4/8  file-notify-test03-events
Reverting buffer `file-notify-test5Qh30O'.
Test file-notify-test04-autorevert backtrace:
  signal(ert-test-failed (((should-not auto-revert-use-notify) :form a
  ert-fail(((should-not auto-revert-use-notify) :form auto-revert-use-
  (if (not (unwind-protect (setq value-208 auto-revert-use-notify) (se
  (let (form-description-209) (if (not (unwind-protect (setq value-208
  (let ((value-208 (gensym "ert-form-evaluation-aborted-"))) (let (for
  (save-current-buffer (set-buffer buf) (let* ((fn-189 (function strin
  (progn (advice-add 'vc-refresh-state :around 'ignore) (setq file-not
  (unwind-protect (progn (advice-add 'vc-refresh-state :around 'ignore
  (let ((timeout (if (file-remote-p temporary-file-directory) 60 10)) 
  (closure (t) nil (let* ((fn-184 (function file-notify--test-local-en
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name file-notify-test04-autorevert :docume
  ert-run-or-rerun-test(#s(ert--stats :selector (not (or (tag :expensi
  ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co
  ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable)))
  ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
  eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (
  command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/filenotify-tests.el"
  command-line()
  normal-top-level()
Test file-notify-test04-autorevert condition:
    (ert-test-failed
     ((should-not auto-revert-use-notify)
      :form auto-revert-use-notify :value t))
   FAILED  5/8  file-notify-test04-autorevert
   passed  6/8  file-notify-test05-file-validity
   passed  7/8  file-notify-test06-dir-validity
   passed  8/8  file-notify-test08-backup

Ran 8 tests, 7 results as expected, 1 unexpected (2018-01-21 20:07:14+0000)

1 unexpected results:
   FAILED  file-notify-test04-autorevert


-- 
Alan Third