Re: package.el strings

[Jean-Christophe Helary]

On Jun 25, 2018, at 0:37, Noam Postavsky <address@hidden> wrote:

On 20 June 2018 at 12:19, Jean-Christophe Helary <address@hidden> wrote:

Et voilà !

===========================
* lisp/emacs-lisp/package.el: reformat message strings for future l10n
===========================

Just one more question

@@ -1015,6 +1017,7 @@ package-buffer-info
  (let ((file-name (match-string-no-properties 1))
        (desc      (match-string-no-properties 2))
        (start     (line-beginning-position)))
+;; The terminating comment could be a generic string that is not in English
    (unless (search-forward (concat ";;; " file-name ".el ends here"))
      (error "Package lacks a terminating comment"))

That comment is basically aspirational, right? That is, currently the
terminating comment can't be a generic string. So I would rephrase it
as

   ;; The terminating comment format could be extended to accept a
   ;; generic string that is not in English.

If you agree, I'll make that change and push.

I don't understand what you mean by "can't be a generic string", for ex can't it be (concat ";;; " file-name ".el <<<<<<<") ?

But regarding the comment itself, I'm OK with anything that you think is better. :)

Jean-Christophe Helary
-----------------------------------------------
http://mac4translators.blogspot.com @brandelune