emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Fixing some warnings in emacs-26


From: Eli Zaretskii
Subject: Re: Fixing some warnings in emacs-26
Date: Sat, 08 Jun 2019 11:43:08 +0300

> From: Juanma Barranquero <address@hidden>
> Date: Sat, 8 Jun 2019 09:07:43 +0200
> Cc: Emacs developers <address@hidden>
> 
> > Instead of the arbitrary value of 20, I'd prefer using sizeof for the
> > actual text (which should probably be assigned to a variable, to avoid
> > mentioning the same text twice).
> 
> Done.
> 
> Though I wanted to avoid adding complexity for a string message that's
> unlikely to change. Also, addpm.c already contains a few instances of
> hardcoded constants:
> 
>       /* Ensure there is enough room for "...\GNU Emacs\Emacs.lnk".  */
>       if (strlen (start_folder) < (MAX_PATH - 20))
> 
> and
> 
>       char add_item[MAX_PATH*2 + 100];
> 
> etc.

Feel free to change them as well, although addpm is deprecated, so I
wonder whether we should bother cleaning up purely stylistic issues in
it.

Thanks.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]