Re: Towards a cleaner build: viper-ex

[Lars Ingebrigtsen]

Eli Zaretskii <address@hidden> writes:

>> In ex-tag:
>> emulation/viper-ex.el:2019:16:Warning: `find-tag' is an obsolete function (as
>>     of 25.1); use `xref-find-definitions' instead.
>> emulation/viper-ex.el:2020:14:Warning: `find-tag-other-window' is an obsolete
>>     function (as of 25.1); use `xref-find-definitions-other-window' instead.
>> 
>> I thought this was going to be trivial to fix, but:
>> 
>>        (if (string= tag "")
>>            (find-tag ex-tag t)
>>          (find-tag-other-window ex-tag))
>
> Time to use the new anti-warning facilities you just introduced?

But presumably this is a real warning about a function that will go away
(and the viper-ex function won't), so it should be fixed by rewriting
this in terms of the xref-* functions.

But I don't know how.  :-)

There's a handful more of similar calls in the Emacs tree.  So what is
the proper way to rewrite calls like (find-tag ex-tag t) in terms of the
new xref-* machinery?

I've Cc'd Dmitry on this now...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no