emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Towards a cleaner build: ieieo


From: Lars Ingebrigtsen
Subject: Re: Towards a cleaner build: ieieo
Date: Thu, 13 Jun 2019 15:50:31 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

But there's more funny stuff going on in eieio:

make[1]: Entering directory '/home/larsi/src/emacs/trunk/lisp'
  ELC      emacs-lisp/eieio.elc
`object-print' is an obsolete generic function (as of 26.1); use 
`cl-print-object' instead.

In toplevel form:
emacs-lisp/eieio.el:850:11:Warning: `object-print' is an obsolete function (as
    of 26.1); use `cl-print-object' instead.

I didn't understand where the first message came from for a while, but
it's here:

(defmacro cl-defmethod (name args &rest body)
  "Define a new method for generic function NAME.

[...]

    (pcase-let* ((`(,uses-cnm . ,fun) (cl--generic-lambda args body)))
      `(progn
         ,(and (get name 'byte-obsolete-info)
               (or (not (fboundp 'byte-compile-warning-enabled-p))
                   (byte-compile-warning-enabled-p 'obsolete))
               (let* ((obsolete (get name 'byte-obsolete-info)))
                 (macroexp--warn-and-return
                  (macroexp--obsolete-warning name obsolete "generic function")
                  nil)))

Is this useful?  I mean, the byte compiler does warn about this later
(and in the correct format), so this seems kinda superfluous?  Or is it
also messages outside of byte-compilation?  If that's the case, should
it be suppressed when we're compiling, and if so, how?  :-)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




reply via email to

[Prev in Thread] Current Thread [Next in Thread]