emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Towards a cleaner build: srecode/insert


From: Lars Ingebrigtsen
Subject: Re: Towards a cleaner build: srecode/insert
Date: Sat, 15 Jun 2019 18:33:19 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

As with much in the eieio/CLOS confusion in CEDET, this left me
scratching my head:

cedet/srecode/insert.el:176:39:Warning: Obsolete name arg "TEMPLATE" to
    constructor srecode-template-inserted-region

So the code is:

             ;; Create the field-driven editable area.
             (srecode-template-inserted-region
              "TEMPLATE" :start start :end (point))))

Let's try it:

(srecode-template-inserted-region "TEMPLATE" :start 1 :end 2)
=> #s(srecode-template-inserted-region #<overlay from 1 to 2 in *unsent
wide reply to Lars Ingebrigtsen*> nil)

Is it literally complaining about that first parameter?

(srecode-template-inserted-region :start 1 :end 2)
=> #s(srecode-template-inserted-region #<overlay from 1 to 2 in *unsent wide 
reply to Lars Ingebrigtsen*> nil)

(equal (srecode-template-inserted-region "TEMPLATE" :start 1 :end 2)
       (srecode-template-inserted-region :start 1 :end 2))
=> t

Indeed?  The name arg is just discarded?  In which case, it seems like
this could be fixed by just removing "TEMPLATE" from all these calls,
but that seems too obvious, so I'm asking. 

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




reply via email to

[Prev in Thread] Current Thread [Next in Thread]