Re: Change in vc-git ls-files-unknown makes emacs hang

[Dmitry Gutov]

Hi Filipp,

On 19.12.2019 16:16, Filipp Gunbin wrote:
> Hi, this commit makes Emacs hang and become unusable, this happens when
> loading the desktop.  Quitting doesn't unfreeze, so I can't get the
> backtrace.  I'm on macOS, tty emacs.

I'm the one who reviewed that patch.

Could you figure out under what circumstances that code 
(vc-git-dir-status-goto-stage which triggers the freeze) gets called 
while loading the desktop? In particular, for which directory (but which 
list of files is passed to vc-git-dir-status-files might also be 
important). And after you figure that out, does VC-Dir work okay in it?

Since backtrace is hard to get, how about some print-debugging with 
logging to a file? write-region should help.

UUIC, the only case where this change should lead to a performance 
problem is a Git repository with lots of unregistered files. Ones not 
hidden by gitignore.