emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] Add support for parsing column numbers in Visual Studio messages


From: Daniel Martín
Subject: [PATCH] Add support for parsing column numbers in Visual Studio messages
Date: Sun, 26 Jul 2020 17:22:20 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.10.0

Hi, all:

The other day I opened a compilation log from a recent version of Visual Studio in Emacs (Visual Studio 2019) and I noticed that Emacs doesn't highlight compilation errors from MSVC 2019 correctly. A simple recipe to reproduce the problem is:

1. emacs -Q

2. Paste the following text:

C:\tmp\sample.cpp(101,11): error C4101: 'bias0123': unreferenced local variable [C:\tmp\libsample.vcxproj] C:\tmp\sample.cpp(101,21): error C4101: 'bias4567': unreferenced local variable [C:\tmp\libsample.vcxproj]

3. M-x compilation-minor-mode

Expected behavior: Errors are highlighted and you can navigate them using compilation-next-error and compilation-previous-error.

Actual behavior: Errors are not highlighted.

The problem seems to happen because the regular expression for MSVC in compile.el doesn't take into account column numbers. Attached is a proposed patch to implement support for it.

Thanks,

Daniel Mart??n

Attachment: 0001-Add-support-for-parsing-column-numbers-in-Visual-Stu.patch
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]