Re: master f450798: Don't move point in vc-dir on vc-register/vc-checkin (bug#43188)

[Andrii Kolomoiets]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> -                  (ewoc-invalidate vc-ewoc node))
>> +                      ;; `ewoc-invalidate' will kill line and insert new 
>> text,
>> +                      ;; let's keep point column.
>> +                      (let ((p (point)))
>> +                    (ewoc-invalidate vc-ewoc node)
>> +                        (goto-char p)))
>
> Shouldn't this be done in `ewoc-invalidate` instead?

Good point!  According 'ewoc-invalidate' docstring, refreshing is done
by deleting the text and inserting the new one thus the 'save-excursion'
is not really helpful.

Please see attached patch.

0001-Save-and-restore-point-in-ewoc-invalidate.patch
Description: Text Data