[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master d378615: Cancel timer when world-clock buffer is killed
From: |
Stefan Kangas |
Subject: |
Re: master d378615: Cancel timer when world-clock buffer is killed |
Date: |
Sun, 6 Sep 2020 15:38:10 +0000 |
"Basil L. Contovounesios" <contovob@tcd.ie> writes:
> Why not keep the (internal) variable and pass it to cancel-timer
> directly instead of searching through timer-list for a particular entry?
Thanks for your attention to detail.
It's a matter of taste, I suppose. While mucking around with this, I
saw two timers at one point, so I just kept that code as is. (Although
the particular issue causing two timers should be fixed now.)
Perhaps this should just use `cancel-function-timers' though...
Are there any strong reasons why keeping it in a variable is better?
Maybe we just prefer that style?