Re: Changes for emacs 28

[Caio Henrique]

Robert Pluim <rpluim@gmail.com> writes:

>>>>>> On Fri, 11 Sep 2020 13:12:05 -0300, Caio Henrique <caiohcs0@gmail.com> 
>>>>>> said:
>
>     Caio> Eli Zaretskii <eliz@gnu.org> writes:
>     >>> From: Robert Pluim <rpluim@gmail.com>
>     >>> Cc: caiohcs0@gmail.com,  rekado@elephly.net,  ghe@sdf.org,
>     >>> spacibba@aol.com,  drew.adams@oracle.com,  emacs-devel@gnu.org
>     >>> Date: Fri, 11 Sep 2020 16:24:23 +0200
>     >>> 
>     >>> if the goal is to save space we could remove the 'Save'
>     >>> and 'Undo' text in the toolbar under Gnu/Linux (the toolbar on macOS
>     >>> has only icons).
>     >> 
>     >> Does the text come from Emacs?  I thought it comes from GTK (I see no
>     >> text on MS-Windows, either).
>
>     Caio> (setq tool-bar-style 'image)
>
>     Caio> That should do the trick for GTK. Maybe this should be its default 
> value?
>
> I agree (but I donʼt use the toolbar :-) )


I believe that this is a bug (see the images attached comparing before
and after this patch). 

_____
diff --git a/lisp/tool-bar.el b/lisp/tool-bar.el
index 7df1e28e06..bec45c1ea4 100644
--- a/lisp/tool-bar.el
+++ b/lisp/tool-bar.el
@@ -256,9 +256,9 @@ tool-bar-setup
   (tool-bar-add-item-from-menu 'dired "diropen" nil :vert-only t)
   (tool-bar-add-item-from-menu 'kill-this-buffer "close" nil :vert-only t)
   (tool-bar-add-item-from-menu 'save-buffer "save" nil
-                              :label "Save")
+                              :label "Save" :vert-only t)
   (define-key-after (default-value 'tool-bar-map) [separator-1] 
menu-bar-separator)
-  (tool-bar-add-item-from-menu 'undo "undo" nil)
+  (tool-bar-add-item-from-menu 'undo "undo" nil :vert-only t)
   (define-key-after (default-value 'tool-bar-map) [separator-2] 
menu-bar-separator)
   (tool-bar-add-item-from-menu (lookup-key menu-bar-edit-menu [cut])
                               "cut" nil :vert-only t)
_____

toolbar-before.png
Description: toolbar before 1

toolbar-before2.png
Description: toolbar before 2

toolbar-patched.png
Description: toolbar after patch 1

toolbar-patched-2.png
Description: toolbar patched 2